feat: allow arrayAttr parsing in constraint #510
Merged
+189
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgehre-amd
reviewed
Mar 20, 2025
mgehre-amd
reviewed
Mar 20, 2025
ehsan-toosi
approved these changes
Mar 20, 2025
mathmer-amd
deleted the
mmerienn.pdll_allow_parsing_of_arrayAttr_in_constraints
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PDLL the syntax
let array = ["attr1", "attr2"];is only usable in rewrite section, but not in constraint section of a pattern.This PR add the parsing of this syntax also in the constraint section of a pattern.
Also, the empty array
[]was considered as a parsing error, this PR fix this little parsing issue.