New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve mid-circuit measurement conversion abilities #417
Conversation
[sc-56131] |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #417 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 380 429 +49
=========================================
+ Hits 380 429 +49 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the walkthrough, here are my initial thoughts from yesterday - I'll go through it again this afternoon :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few more little things here and there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few minor suggestions, but nothing blocking. Looks good to me 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding in those test additions. Looks good to me :)
c_if
(legacy),IfElseOp
, andSwitchCaseOp
ForLoopOp
andWhileLoopOp
, mainly because doing them withqml.cond
doesn't seem possible at the moment.