Fixes ledger version in getTrustlines
#1505
Merged
+15
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvadari
requested review from
intelliot,
JST5000,
khancode,
ledhed2222,
natenichols and
mukulljangid
natenichols
reviewed
Aug 4, 2021
src/ledger/trustlines.ts
Outdated
| @@ -31,7 +31,7 @@ async function getTrustlines( | |||
| // 2. Make Request | |||
| const responses = await this._requestAll('account_lines', { | |||
| account: address, | |||
| ledger_index: await this.getLedgerVersion(), | |||
| ledger_index: options.ledgerVersion, | |||
There was a problem hiding this comment.
I think we still want to default to this.getLedgerVersion() when no options is provided.
Can we do something like
let ledger_index = options.ledgerVersion
if (ledger_index === undefined)
ledger_index = await this.getLedgerVersion()
const responses = await this._requestAll('account_lines', {
........
ledger_index,
........
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
getTrustlineswasn't usingledgerVersionin the options at all, and was instead getting the current ledger version. This PR fixes that.Context of Change
Fixes #1501
Type of Change
Before / After
Test Plan
Added a test to check for the correct behavior. CI passes.