-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TrustlineTransaction type #1458
Comments
mrosendin
added a commit
to trustline-inc/ripple-lib
that referenced
this issue
Jul 12, 2021
I am unable to create a branch, but I pushed the fix to a fork: c3013dd |
@mrosendin You should be able to create a PR for this repo from your fork |
@intelliot PR created: #1460 |
Released in ripple-lib version 1.9.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The typings for
FormattedTrustlineTransaction
need to be updated.Gives TypeScript errors like
Property 'limit' does not exist on type 'FormattedTrustline'.
for each property.The error goes away if I instead do
transaction.specification.specification.limit!
, but this property doesn't exist on the object.This leads me to believe that the typings are somehow incorrect for
FormattedTrustline
(see FormattedTrustlineTransaction and FormattedTrustlineSpecification)
Example of a trust line object returned from the API:
I can submit a PR to fix this.
The text was updated successfully, but these errors were encountered: