Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit docs for style and update old URLs #1420

Merged
merged 4 commits into from
Jul 27, 2021
Merged

Edit docs for style and update old URLs #1420

merged 4 commits into from
Jul 27, 2021

Conversation

mDuo13
Copy link
Collaborator

@mDuo13 mDuo13 commented May 28, 2021

Updates the documentation to better follow our style guide and use plain language where possible. Also replaces a lot of old ripple.com URLs with more updated equivalents.

This is not a comprehensive review based on reading and trying to better understand the docs. That would be useful, but for this PR I've mostly used find-and-replace to fix some of the more obvious issues.

@mDuo13 mDuo13 requested a review from intelliot May 28, 2021 20:58
@intelliot intelliot requested review from mvadari and natenichols July 27, 2021 17:32
Copy link
Collaborator

@mvadari mvadari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@natenichols natenichols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the unit tests pass, this LGTM.

Use example.com instead of ripple.com in unit tests
@intelliot intelliot merged commit 4e49b6a into develop Jul 27, 2021
@intelliot intelliot deleted the doc_style_edits branch July 27, 2021 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants