Global styles panel header buttons text overlaps when 'Show button text labels' is enabled #61761
Labels
[Feature] Show button text labels
A preference in the Post and Site Editor that makes buttons show text instead of icons
[Focus] Accessibility (a11y)
Changes that impact accessibility and need corresponding review (e.g. markup changes).
Needs Design Feedback
Needs general design feedback.
[Package] Edit Site
/packages/edit-site
[Type] Regression
Related to a regression in the latest release
Description
When the 'Show button text labels' preference is enabled, the text of the buttons in the Styles panel header overlaps, making thte text barely readable.
Screenshot from trunk:
This appears to be a regression from WordPress 6.5, where the text is readable. Screenshot:
I think the recent addition of the
is-compact
CSS class and styling to the buttons hasn't been tested for 'Show button text labels'. Regardless, the buttons text should never overlap.Worth noting the horizontal space in the panel header is very limited. Placing there a title, 3 action buttons and a close button doesn't seem ideal in the first place.
On the other hand, the 'Show button text labels' preference seems to be often neglected and missed during the design and testing phase. I'd love to see this feature being treated as a first-class citizen in this project at the point that I'd think anydesign for new feature should provide design and mockups for 'Show button text labels' as well.
Note: I created a new GitHub label
[Feature] Show button text labels
, similarly to other used preferences like[Feature] Distraction Free
to better track issues related to it. Thre have been several issues and PRs to remediate to breakages of buttons with this prefrence enabled that are all scattered around and difficult to search for.Step-by-step reproduction instructions
Screenshots, screen recording, code snippet
No response
Environment info
No response
Please confirm that you have searched existing issues in the repo.
Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Yes
The text was updated successfully, but these errors were encountered: