Add support for electron v35 prebuilds
#1340
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ubuntu 20.04 runner is being phased out. They're failing the jobs during the deprecation period and today is apparently one of those days. 😄 |
So... Do we drop support for Ubuntu 20? LTS support ends 31 May 2025 -- I think it's reasonable. The alternative is to build the glibc artifacts with ubuntu 20 in a docker container, which is a PITA. |
|
@m4heshd if you can make a PR to the (Ubuntu 22 LTS EOL's on April 2027: see https://wiki.ubuntu.com/Releases) |
ArGeoph
pushed a commit
to ArGeoph/better-sqlite3
that referenced
this pull request
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stable electron v35 just released. Prebuilds were tested here.