Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in "stable" and "oldstable" #31

Closed
Jacalz opened this issue Jan 15, 2024 · 3 comments · Fixed by #32
Closed

Add in "stable" and "oldstable" #31

Jacalz opened this issue Jan 15, 2024 · 3 comments · Fixed by #32

Comments

@Jacalz
Copy link

Jacalz commented Jan 15, 2024

Just the stable input. I don't understand what stable adds for actions/setup-go. If you only want stable builds you can set go-version accordingly. If there is good use case for stable, it can be added.

The README mentions that stable hasn't been added. I believe it would be very good to add it because it means that the workflow file can be the same without having to create a new commit (plus PR depending on the project). The same goes for using oldstable for the older maintained release. Using these two makes it possible to basically have a fire-and-forget workflow that constantly keeps updated to test with the latest supported Go versions.

This goes hand in hand with my issue over at setup-go: actions/setup-go#450

@WillAbides
Copy link
Owner

Thanks for bringing this up. You can already simulate stable by setting go-version: 1.x, but I don't think there is a way to simulate oldstable. Your use case seems valid, and there doesn't seem to be a downside, so I'm inclined to add this. I'll be looking at it today, but I can't be sure when a PR will land.

As an aside, the part of the README you quoted is referencing the "stable" input as it existed in actions/setup-go@v2. v3 dropped that input and replaced it with the stable and oldstable aliases.

@WillAbides
Copy link
Owner

This is released in v1.14.0

@Jacalz
Copy link
Author

Jacalz commented Jan 16, 2024

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants