packages/conversations/__tests__/__dataSets__/post.ts

@@ -36,7 +36,10 @@ export default [
           callback: {
             url: conversationToCreate?.callback?.url,
             event_mask: conversationToCreate?.callback?.eventMask,
-            params: conversationToCreate?.callback?.params,
+            params:{
+              applicationId: conversationToCreate?.callback?.params?.applicationId,
+              ncco_url: conversationToCreate?.callback?.params?.nccoUrl,
+            }, 
             method: conversationToCreate?.callback?.method,
           },
         } as CreateConversationRequest,
@@ -109,4 +112,40 @@ export default [
     error: false,
     expected: event,
   },
+  {
+    label: 'create conversation with callback',
+    requests: [
+      [
+        '/v1/conversations',
+        'POST',
+        {
+          name: conversationToCreate.name,
+          display_name: conversationToCreate.displayName,
+          image_url: conversationToCreate.imageUrl,
+          properties: {
+            ttl: conversationToCreate?.properties?.ttl,
+            type: conversationToCreate?.properties?.type,
+            custom_sort_key: conversationToCreate?.properties?.customSortKey,
+            custom_data: conversationToCreate?.properties?.customData,
+          },
+          numbers: conversationToCreate?.numbers,
+          callback: {
+            url: conversationToCreate?.callback?.url,
+            event_mask: conversationToCreate?.callback?.eventMask,
+            params: {
+              applicationId: conversationToCreate?.callback?.params?.applicationId,
+              ncco_url: conversationToCreate?.callback?.params?.nccoUrl,
+            },
+            method: conversationToCreate?.callback?.method,
+          },
+        } as CreateConversationRequest,
+      ],
+    ],
+    responses: [[200, conversationResponse]],
+    clientMethod: 'createConversation',
+    parameters: [conversationToCreate],
+    generator: false,
+    error: false,
+    expected: conversation,
+  },
 ];

packages/conversations/__tests__/__dataSets__/put.ts

@@ -26,7 +26,10 @@ export default [
           callback: {
             url: conversationToCreate?.callback?.url,
             event_mask: conversationToCreate?.callback?.eventMask,
-            params: conversationToCreate?.callback?.params,
+            params: {
+              applicationId: conversationToCreate?.callback?.params?.applicationId,
+              ncco_url: conversationToCreate?.callback?.params?.nccoUrl,
+            },
             method: conversationToCreate?.callback?.method,
           },
         } as CreateConversationRequest,

packages/conversations/__tests__/common.ts

@@ -40,7 +40,10 @@ export const conversationToCreate = Object.freeze({
   callback: {
     url: 'https://example.com/callback',
     eventMask: EventType.AUDIO_PLAY,
-    params: {},
+    params: {
+      applicationId: 'APP-00000000-0000-0000-0000-000000000001',
+      nccoUrl: 'https://example.com/ncco',
+    },
     method: 'POST',
   }
 }) as Conversation;

packages/conversations/lib/conversations.ts

@@ -57,6 +57,13 @@ const conversationToApi = (
     apiConversation.properties.custom_data = customData;
   }
 
+  if (conversation?.callback?.params?.applicationId && apiConversation?.callback?.params) {
+    apiConversation.callback.params = {
+      applicationId: conversation.callback.params.applicationId,
+      ncco_url: conversation.callback.params.nccoUrl,
+    };
+  }
+
   return apiConversation;
 };
 

packages/conversations/lib/types/requests/conversationCallbackRequest.ts

@@ -19,12 +19,12 @@ export type ConversationCallbackRequest = {
     /**
      * The application ID for the callback.
      */
-    application_id: string;
+    applicationId?: string;
 
     /**
      * The NCCO URL for the callback.
      */
-    ncco_url: string;
+    ncco_url?: string;
   };
 
   /**

packages/conversations/package.json

@@ -1,7 +1,7 @@
 {
   "$schema": "https://json.schemastore.org/package.json",
   "name": "@vonage/conversations",
-  "version": "1.7.1",
+  "version": "1.7.2",
   "description": "The Vonage Conversation API enables you to build conversation features where communication can take place across multiple mediums including IP Messaging, PSTN Voice, SMS and WebRTC Audio and Video. The context of the conversations is maintained though each communication event taking place within a conversation, no matter the medium.",
   "homepage": "https://github.com/vonage/vonage-node-sdk/tree/main/packages/conversations#readme",
   "bugs": {

packages/number-insight-v2/README.md

@@ -33,34 +33,7 @@ yarn add @vonage/number-insight-v2
 
 ## Usage
 
-### As part of the Vonage Server SDK
-
-If you are using this SDK as part of the Vonage Server SDK, you can access it as the `numberInsightV2` property off of the client that you instantiate.
-
-```js
-const { Auth } = require('@vonage/auth');
-const { Vonage } = require('@vonage/server-sdk');
-const { Insight } = require('@vonage/number-insight-v2');
-
-const credentials = new Auth({
-  apiKey: API_KEY,
-  apiSecret: API_SECRET
-});
-const options = {};
-const vonage = new Vonage(credentials, options);
-
-vonage.numberInsightV2.checkForFraud({
-  type: 'phone',
-  phone: PHONE_NUMBER,
-  insights: [Insight.SIM_SWAP, Insight.FRAUD_SCORE],
-})
-  .then(resp => console.log(resp))
-  .catch(err => console.error(err));
-```
-
-### Standalone
-
-The SDK can be used standalone from the main [Vonage Server SDK for Node.js](https://github.com/vonage/vonage-node-sdk) if you only need to use the Number Insight v2 API. All you need to do is `require('@vonage/number-insight-v2')`, and use the returned object to create your own client.
+Unlike the other SDK's this package is not include in the [Vonage Server SDK for Node.js](https://github.com/vonage/vonage-node-sdk)
 
 ```js
 const { Auth } = require('@vonage/auth');

packages/number-insight-v2/package.json

@@ -1,7 +1,7 @@
 {
   "$schema": "https://json.schemastore.org/package.json",
   "name": "@vonage/number-insight-v2",
-  "version": "1.8.1",
+  "version": "1.8.3",
   "description": "Number Insight v2 is designed to give fraud scores for Application Integrations.",
   "homepage": "https://github.com/vonage/vonage-node-sdk/tree/main/packages/number-insight-v2#readme",
   "bugs": {

packages/server-sdk/package.json

@@ -1,7 +1,7 @@
 {
   "$schema": "https://json.schemastore.org/package.json",
   "name": "@vonage/server-sdk",
-  "version": "3.19.1",
+  "version": "3.19.2",
   "description": "Node.js Client for the Vonage API Platform",
   "homepage": "https://developer.vonage.com",
   "bugs": {
@@ -41,7 +41,7 @@
     "@vonage/accounts": "^1.16.1",
     "@vonage/applications": "^1.16.1",
     "@vonage/auth": "^1.12.0",
-    "@vonage/conversations": "^1.7.1",
+    "@vonage/conversations": "^1.7.2",
     "@vonage/messages": "^1.18.1",
     "@vonage/number-insights": "^1.16.1",
     "@vonage/numbers": "^1.16.1",