Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: avoid autoinstalling manually uninstalled commands #73

Merged
merged 30 commits into from
May 23, 2023

Conversation

alestiago
Copy link
Contributor

@alestiago alestiago commented May 18, 2023

Status

READY

Description

Closes #57

Changes:

  • Adds rootCommand to uninstall list when uninstalled
  • Removes rootCommand from uninstall list when installed
  • Checks if rootCommand is uninstalled before auto install

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Sorry, something went wrong.

alestiago added 19 commits May 18, 2023 12:11

Verified

This commit was signed with the committer’s verified signature.
alestiago Alejandro Santiago

Verified

This commit was signed with the committer’s verified signature.
alestiago Alejandro Santiago

Verified

This commit was signed with the committer’s verified signature.
alestiago Alejandro Santiago

Verified

This commit was signed with the committer’s verified signature.
alestiago Alejandro Santiago

Verified

This commit was signed with the committer’s verified signature.
alestiago Alejandro Santiago

Verified

This commit was signed with the committer’s verified signature.
alestiago Alejandro Santiago

Verified

This commit was signed with the committer’s verified signature.
alestiago Alejandro Santiago

Verified

This commit was signed with the committer’s verified signature.
alestiago Alejandro Santiago

Verified

This commit was signed with the committer’s verified signature.
alestiago Alejandro Santiago

Verified

This commit was signed with the committer’s verified signature.
alestiago Alejandro Santiago

Verified

This commit was signed with the committer’s verified signature.
alestiago Alejandro Santiago

Verified

This commit was signed with the committer’s verified signature.
alestiago Alejandro Santiago

Verified

This commit was signed with the committer’s verified signature.
alestiago Alejandro Santiago

Verified

This commit was signed with the committer’s verified signature.
alestiago Alejandro Santiago

Verified

This commit was signed with the committer’s verified signature.
alestiago Alejandro Santiago

Verified

This commit was signed with the committer’s verified signature.
alestiago Alejandro Santiago

Verified

This commit was signed with the committer’s verified signature.
alestiago Alejandro Santiago

Verified

This commit was signed with the committer’s verified signature.
alestiago Alejandro Santiago

Verified

This commit was signed with the committer’s verified signature.
alestiago Alejandro Santiago
@alestiago alestiago marked this pull request as ready for review May 22, 2023 17:00
@alestiago alestiago self-assigned this May 22, 2023

Verified

This commit was signed with the committer’s verified signature.
alestiago Alejandro Santiago
alestiago added 10 commits May 23, 2023 18:32

Verified

This commit was signed with the committer’s verified signature.
alestiago Alejandro Santiago

Verified

This commit was signed with the committer’s verified signature.
alestiago Alejandro Santiago

Verified

This commit was signed with the committer’s verified signature.
alestiago Alejandro Santiago

Verified

This commit was signed with the committer’s verified signature.
alestiago Alejandro Santiago

Verified

This commit was signed with the committer’s verified signature.
alestiago Alejandro Santiago

Verified

This commit was signed with the committer’s verified signature.
alestiago Alejandro Santiago

Verified

This commit was signed with the committer’s verified signature.
alestiago Alejandro Santiago

Verified

This commit was signed with the committer’s verified signature.
alestiago Alejandro Santiago

Verified

This commit was signed with the committer’s verified signature.
alestiago Alejandro Santiago

Verified

This commit was signed with the committer’s verified signature.
alestiago Alejandro Santiago
Copy link
Contributor

@renancaraujo renancaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏾

@alestiago alestiago merged commit 527db4c into main May 23, 2023
@alestiago alestiago deleted the feat/avoid-autoinstalling-uninstalls branch May 23, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

feat: Add uninstall behavior
3 participants