Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support extracting image url in html #3955

Merged
merged 11 commits into from
Mar 13, 2025

Conversation

ryannikolaidis
Copy link
Contributor

also removes mimetype when base64 is not included in image metadata

ryannikolaidis and others added 10 commits March 12, 2025 17:01
…date (#3956)

This pull request includes updated ingest test fixtures.
Please review and merge if appropriate.

Co-authored-by: ryannikolaidis <ryannikolaidis@users.noreply.github.com>
…ured-IO/unstructured into ryan/extract-image-src-metadata
Copy link
Contributor

@christinestraub christinestraub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a small comment:

What about changing file name of "html-with-base64-image.html" to "fake-html-with-image-from-base64.html" for consistency?

@ryannikolaidis ryannikolaidis added this pull request to the merge queue Mar 13, 2025
Merged via the queue into main with commit 66bf4b0 Mar 13, 2025
43 checks passed
@ryannikolaidis ryannikolaidis deleted the ryan/extract-image-src-metadata branch March 13, 2025 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants