Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move feature overview header into separate file #9319

Merged

Conversation

thomasheartman
Copy link
Contributor

@thomasheartman thomasheartman commented Feb 18, 2025

This PR moves the flag page header into a separate file, so that the overview file is more clearly focused on the overview.

Additionally, it moves the modals that are triggered from the header into the new file. This should give a nice little performance boost, as opening and closing these modals should no longer trigger a re-rendering of the full flag overview page, only the header.

Verified

This commit was signed with the committer’s verified signature.
thomasheartman Thomas Heartman

Verified

This commit was signed with the committer’s verified signature.
thomasheartman Thomas Heartman

Verified

This commit was signed with the committer’s verified signature.
thomasheartman Thomas Heartman
Copy link

vercel bot commented Feb 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 10:13am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Feb 18, 2025 10:13am

Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@thomasheartman thomasheartman changed the title chore: handle narrow windows for new flag page header refactor: move feature overview header into separate file Feb 18, 2025
@thomasheartman thomasheartman merged commit 4701dc1 into main Feb 18, 2025
13 checks passed
@thomasheartman thomasheartman deleted the chore(1-3371)/handle-narrow-windows-in-flag-header branch February 18, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants