fix(1-3377): handle singular counts in project status lifecycle boxes #9317
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the average number of days in a stage is 1, use `1 day` instead of `1 days`. Likewise, if your total number of archived flags is 1, use `1 flag archived` instead of `1 flags archived`.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
Tymek
reviewed
Feb 17, 2025
Comment on lines
170
to
173
| const totalArchivedStat = () => { | ||
| const count = data?.lifecycleSummary.archived.last30Days ?? 0; | ||
| return `${count} ${count === 1 ? 'flag' : 'flags'} archived`; | ||
| }; |
There was a problem hiding this comment.
this can be a variable, not a function
There was a problem hiding this comment.
It can be, but I'm not sure what you get from it. doing it as a function gives you scope to name variables and separate it from other stuff. I don't mind, though 🤷🏼
There was a problem hiding this comment.
Scoping is a for of an abstraction - to me it makes this code less declarative, less "linear" to read if you need to understand everything that's going on, instead of trusting the function name
Tymek
approved these changes
Feb 17, 2025
thomasheartman
deleted the
fix(1-3377)/singular-plural-in-project-status
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the average number of days in a stage is 1, use
1 dayinstead of1 days.Likewise, if your total number of archived flags is 1, use
1 flag archivedinstead of1 flags archived.I grepped through the file, but couldn't find any other hardcoded instances of "flags" or "days", so I think this is everything.