fix: add a metric to track client registrations #9314
Merged
+18
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
kwasniew
reviewed
Feb 14, 2025
| @@ -807,6 +812,9 @@ export function registerPrometheusMetrics( | |||
| clientDeltaMemory.reset(); | |||
| clientDeltaMemory.set(event.memory); | |||
| }); | |||
| eventBus.on(events.CLIENT_REGISTERED, ({ appName, environment }) => { | |||
There was a problem hiding this comment.
I'm assuming we don't need to batch those before calling inc
There was a problem hiding this comment.
no need, its just in-memory counters.
kwasniew
reviewed
Feb 14, 2025
| @@ -105,6 +111,7 @@ export default class ClientInstanceService { | |||
| value.clientIp = clientIp; | |||
| value.createdBy = SYSTEM_USER.username!; | |||
| this.seenClients[this.clientKey(value)] = value; | |||
| this.eventBus.emit(CLIENT_REGISTERED, value); | |||
There was a problem hiding this comment.
it's slightly confusing the we have CLIENT_REGISTER and CLIENT_REGISTERED events
kwasniew
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a counter to track every time a client registers with Unleash.