Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: theme - font size #9273

Merged
merged 3 commits into from
Feb 11, 2025
Merged

refactor: theme - font size #9273

merged 3 commits into from
Feb 11, 2025
+1,275 −113

Conversation

Tymek
Copy link
Member

@Tymek Tymek commented Feb 10, 2025 •
edited
Loading

About the changes

Update body1 size to match 15px, and match other 1rem sizes.

Discussion points

  • Is there a benefit to keeping sizing part of the dark and light theme separate? I refactored it into 1, to get rid of duplication.
  • Should we attempt to put this behind a flag?

@Tymek
refactor: theme font size

Verified

This commit was signed with the committer’s verified signature.
Artyop Antony R.
SSH Key Fingerprint: C2Qke3ebU5dQyPPuq2sL3/7aljJ+nVEEaRRISyaojnA
Verified
Learn about vigilant mode
Loading
Loading status checks…
26cea17
@vercel Vercel
Copy link

vercel bot commented Feb 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 1:51pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Feb 10, 2025 1:51pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 10, 2025 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Tymek added 2 commits February 10, 2025 14:46
@Tymek
add legacy theme for flaggging

Verified

This commit was signed with the committer’s verified signature.
Artyop Antony R.
SSH Key Fingerprint: C2Qke3ebU5dQyPPuq2sL3/7aljJ+nVEEaRRISyaojnA
Verified
Learn about vigilant mode
Loading
Loading status checks…
9e54cad
@Tymek
update theme mode with new sizes

Verified

This commit was signed with the committer’s verified signature.
Artyop Antony R.
SSH Key Fingerprint: C2Qke3ebU5dQyPPuq2sL3/7aljJ+nVEEaRRISyaojnA
Verified
Learn about vigilant mode
Loading
Loading status checks…
f51ced9
@Tymek Tymek merged commit 23e8040 into main Feb 11, 2025
7 of 11 checks passed
@Tymek Tymek deleted the 1-3353 branch February 11, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasheartman thomasheartman

@FredrikOseberg FredrikOseberg

Assignees

@Tymek Tymek

Labels
None yet
Projects
Issues and PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Tymek @thomasheartman