- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move timeline to panel #9243
feat: move timeline to panel #9243
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
@@ -184,6 +185,7 @@ export const EventTimeline = () => { | |||
const startDate = sub(endDate, timeSpan.value); | |||
const endTime = endDate.getTime(); | |||
const startTime = startDate.getTime(); | |||
const showSignalsLink = !useUiFlag('frontendHeaderRedesign'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused and can be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, you're right! Thought the linter would pick it up. But addressed in 5dc4399
</StyledFilter> | ||
)} | ||
/> | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Co-authored-by: Nuno Góis <github@nunogois.com>
</AccordionContent> | ||
</StyledAccordionDetails> | ||
</SectionAccordion> | ||
) : null} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can do showTimelinePanel && (
instead of the ternary so we avoid this : null
at the end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup. Was going to and then forgot 💁🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Co-authored-by: Nuno Góis <github@nunogois.com>
Moves the event timeline to the personal dashboard from the header when the
frontendHeaderRedesign
flag is active.When the flag is active, it also: