Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move timeline to panel #9243

Merged

Conversation

thomasheartman
Copy link
Contributor

@thomasheartman thomasheartman commented Feb 6, 2025

Moves the event timeline to the personal dashboard from the header when the frontendHeaderRedesign flag is active.

When the flag is active, it also:

  • hides the event timeline and corresponding button in the header
  • renders the environment selector next to the time selector instead of at the other end of the header

image

Verified

This commit was signed with the committer’s verified signature.
thomasheartman Thomas Heartman

Verified

This commit was signed with the committer’s verified signature.
thomasheartman Thomas Heartman

Verified

This commit was signed with the committer’s verified signature.
thomasheartman Thomas Heartman

Verified

This commit was signed with the committer’s verified signature.
thomasheartman Thomas Heartman

Verified

This commit was signed with the committer’s verified signature.
thomasheartman Thomas Heartman

Verified

This commit was signed with the committer’s verified signature.
thomasheartman Thomas Heartman
Copy link

vercel bot commented Feb 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 1:56pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Feb 6, 2025 1:56pm

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Verified

This commit was signed with the committer’s verified signature.
thomasheartman Thomas Heartman

Verified

This commit was signed with the committer’s verified signature.
thomasheartman Thomas Heartman

Verified

This commit was signed with the committer’s verified signature.
thomasheartman Thomas Heartman

Verified

This commit was signed with the committer’s verified signature.
thomasheartman Thomas Heartman
@@ -184,6 +185,7 @@ export const EventTimeline = () => {
const startDate = sub(endDate, timeSpan.value);
const endTime = endDate.getTime();
const startTime = startDate.getTime();
const showSignalsLink = !useUiFlag('frontendHeaderRedesign');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused and can be removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you're right! Thought the linter would pick it up. But addressed in 5dc4399

</StyledFilter>
)}
/>
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Verified

This commit was signed with the committer’s verified signature.
thomasheartman Thomas Heartman

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: Nuno Góis <github@nunogois.com>
</AccordionContent>
</StyledAccordionDetails>
</SectionAccordion>
) : null}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can do showTimelinePanel && ( instead of the ternary so we avoid this : null at the end.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. Was going to and then forgot 💁🏼

Copy link
Member

@nunogois nunogois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

thomasheartman and others added 3 commits February 6, 2025 14:49

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: Nuno Góis <github@nunogois.com>

Verified

This commit was signed with the committer’s verified signature.
thomasheartman Thomas Heartman

Verified

This commit was signed with the committer’s verified signature.
thomasheartman Thomas Heartman
@thomasheartman thomasheartman enabled auto-merge (squash) February 6, 2025 13:52
@thomasheartman thomasheartman enabled auto-merge (squash) February 6, 2025 13:53
@thomasheartman thomasheartman merged commit 56c9584 into main Feb 6, 2025
10 of 11 checks passed
@thomasheartman thomasheartman deleted the feat(cjux-328)/events-timeline-on-personal-dashboard branch February 6, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants