feat: move timeline to panel #9243
Merged
+131
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
nunogois
reviewed
Feb 6, 2025
| @@ -184,6 +185,7 @@ export const EventTimeline = () => { | |||
| const startDate = sub(endDate, timeSpan.value); | |||
| const endTime = endDate.getTime(); | |||
| const startTime = startDate.getTime(); | |||
| const showSignalsLink = !useUiFlag('frontendHeaderRedesign'); | |||
There was a problem hiding this comment.
Oh, you're right! Thought the linter would pick it up. But addressed in 5dc4399
nunogois
reviewed
Feb 6, 2025
| </StyledFilter> | ||
| )} | ||
| /> | ||
| ); |
nunogois
reviewed
Feb 6, 2025
Co-authored-by: Nuno Góis <github@nunogois.com>
nunogois
reviewed
Feb 6, 2025
| </AccordionContent> | ||
| </StyledAccordionDetails> | ||
| </SectionAccordion> | ||
| ) : null} |
There was a problem hiding this comment.
Can do showTimelinePanel && ( instead of the ternary so we avoid this : null at the end.
There was a problem hiding this comment.
Yup. Was going to and then forgot 💁🏼
nunogois
reviewed
Feb 6, 2025
Co-authored-by: Nuno Góis <github@nunogois.com>
thomasheartman
deleted the
feat(cjux-328)/events-timeline-on-personal-dashboard
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the event timeline to the personal dashboard from the header when the
frontendHeaderRedesignflag is active.When the flag is active, it also: