chore: use union type for traffic search data #9221
Merged
+91
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the data returned from the traffic search a union type to avoid nasty object-is-undefined errors at runtime. It requires more explicit handling, sure, but it means we don't need to accept undefined.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
thomasheartman
commented
Feb 5, 2025
There was a problem hiding this comment.
This is the main part of this PR: change the type to only have a data property if we actually have something. This means we don't need to keep checking "what if data isn't there" means we need to handle it more explicitly.
daveleek
reviewed
Feb 5, 2025
Comment on lines
-36
to
40
| const totalUsage = calculateTotalUsage(usage); | ||
| if (result.state !== 'success') { | ||
| return 0; | ||
| } | ||
|
|
||
| const totalUsage = calculateTotalUsage(result.data); | ||
| return calculateOverageCost( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the data returned from the traffic search a union type to avoid
nasty object-is-undefined errors at runtime.
It requires more explicit handling, sure, but it means we don't need
to accept undefined.