Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: period selector component #9202

Merged
merged 5 commits into from
Feb 4, 2025

Conversation

thomasheartman
Copy link
Contributor

@thomasheartman thomasheartman commented Feb 4, 2025

Refactors the period selector component now that the design / system is pretty much finished.

Main points are: change from using CSS selectors to using styled components; use props instead of classes. This is in keeping with the general Unleash approach.

There's two very slight visual changes here:

  1. There is 4px of added space below the "range" "header" text.
  2. The months in the grid are a little closer together and not as wide. This is because we remove the explicit column gap due to the grid having a set width. Previously the width was automatic, but because we want this to line up with the button, we need to set the width explicitly on both items. As such, with the padding, the grid was a little too wide, so there was too little padding on the right. This rectifies that.

Verified

This commit was signed with the committer’s verified signature.
sjaanus Jaanus Sellin

Verified

This commit was signed with the committer’s verified signature.
sjaanus Jaanus Sellin

Verified

This commit was signed with the committer’s verified signature.
sjaanus Jaanus Sellin

Verified

This commit was signed with the committer’s verified signature.
sjaanus Jaanus Sellin

Verified

This commit was signed with the committer’s verified signature.
sjaanus Jaanus Sellin
Copy link

vercel bot commented Feb 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 9:52am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Feb 4, 2025 9:52am

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link
Contributor

@daveleek daveleek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thomasheartman thomasheartman merged commit 96dac84 into main Feb 4, 2025
12 of 13 checks passed
@thomasheartman thomasheartman deleted the refactor(1-3280)/period-selector branch February 4, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants