Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drag to reorder release plan template milestones #9176

Merged
merged 3 commits into from
Jan 31, 2025

Conversation

nunogois
Copy link
Member

@nunogois nunogois commented Jan 30, 2025

https://linear.app/unleash/issue/2-2821/drag-to-reorder-template-milestones

This PR introduces reordering release plan template milestones by dragging and dropping them.

Was a bit undecided on the approach, but it seems like using an old useDragItem hook we have is pretty elegant and behaves as expected.

I suggest reviewers try it out themselves.

Includes a slight refactor to useDragItem, which so far is only used here and in environments. I manually tested, but I suggest trying that one out as well just in case.

image

@nunogois nunogois requested a review from daveleek January 30, 2025 15:20
Copy link

vercel bot commented Jan 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 4:27pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Jan 30, 2025 4:27pm

Copy link
Contributor

github-actions bot commented Jan 30, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link
Contributor

@daveleek daveleek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good and seems to work well when trying it out as well!

@nunogois nunogois merged commit 25e8f80 into main Jan 31, 2025
11 checks passed
@nunogois nunogois deleted the chore-drag-to-reorder-template-milestones branch January 31, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants