Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: segment implementation in delta #9148

Merged
merged 6 commits into from
Jan 28, 2025
Merged

feat: segment implementation in delta #9148

merged 6 commits into from
Jan 28, 2025

Conversation

sjaanus
Copy link
Contributor

@sjaanus sjaanus commented Jan 24, 2025

This is implementing the segments events for delta API. Previous version of delta API, we were just sending all of the segments. Now we will have segment-updated and segment-removed events coming to SDK.

Verified

This commit was signed with the committer’s verified signature.
sjaanus Jaanus Sellin
Copy link

vercel bot commented Jan 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 11:34am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Jan 28, 2025 11:34am

Copy link
Contributor

@sjaanus, core features have been modified in this pull request. Please review carefully!

Copy link
Contributor

github-actions bot commented Jan 24, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Verified

This commit was signed with the committer’s verified signature.
sjaanus Jaanus Sellin
@sjaanus sjaanus changed the title WIP feat: segment implementation in delta feat: segment implementation in delta Jan 28, 2025
@sjaanus sjaanus marked this pull request as ready for review January 28, 2025 07:53

Verified

This commit was signed with the committer’s verified signature.
sjaanus Jaanus Sellin

Verified

This commit was signed with the committer’s verified signature.
sjaanus Jaanus Sellin

Verified

This commit was signed with the committer’s verified signature.
sjaanus Jaanus Sellin
Copy link
Contributor

@FredrikOseberg FredrikOseberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines 217 to 227
expect(body).toMatchObject({
events: [
{
features: [
{
name: 'base_feature',
},
],
},
],
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this hydration event?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, added for test to also verify.

Verified

This commit was signed with the committer’s verified signature.
sjaanus Jaanus Sellin
@sjaanus sjaanus merged commit d993b19 into main Jan 28, 2025
12 checks passed
@sjaanus sjaanus deleted the segment-impl-delta branch January 28, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants