feat: rename lifecycle stages #9102
Merged
+651
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
Tymek
commented
Jan 15, 2025
Comment on lines
+165
to
+176
| const stageName = (stage: keyof ProjectStatusSchemaLifecycleSummary) => { | ||
| if (!isLifecycleImprovementsEnabled) { | ||
| return `${flagWord('initial')} in ${stage}`; | ||
| } | ||
|
|
||
| const lifecycleStageName = stage === 'preLive' ? 'pre-live' : stage; | ||
| return ( | ||
| <StyledStageTitle> | ||
| {flagWord(stage)} in{' '} | ||
| {getFeatureLifecycleName(lifecycleStageName)} stage | ||
| </StyledStageTitle> | ||
| ); |
There was a problem hiding this comment.
This can be simplified after removing a flag.
Tymek
commented
Jan 15, 2025
There was a problem hiding this comment.
Just a copy of previous version.
Tymek
requested review from
thomasheartman and
kwasniew
and removed request for
thomasheartman
kwasniew
reviewed
Jan 15, 2025
| @@ -1,10 +1,12 @@ | |||
| import { FeatureLifecycleStageIcon } from './FeatureLifecycleStageIcon'; | |||
| import { FeatureLifecycleStageIcon } from '../../../../common/FeatureLifecycle/FeatureLifecycleStageIcon'; | |||
kwasniew
reviewed
Jan 15, 2025
| type TimedStage = { enteredStageAt: string }; | ||
| export type LifecycleStage = TimedStage & | ||
| ( | ||
| | { name: 'initial' } | ||
| | { name: 'initial' & Lifecycle['stage'] } |
There was a problem hiding this comment.
what is the reason for the new type extension?
There was a problem hiding this comment.
To make sure we have the same keys from the API. If we change the API, this should fail.
kwasniew
reviewed
Jan 15, 2025
| @@ -0,0 +1,161 @@ | |||
| import { screen } from '@testing-library/react'; | |||
There was a problem hiding this comment.
I guess we have the same code in the FeautreLifecycleTooltip.test.tsx and this one will be soon removed so we keep git history for the new code
There was a problem hiding this comment.
Not 1:1 the same, but yes. I'll remove this file
kwasniew
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Name names for "lifecycle" stages, and aligning frontend types.