Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve the accordion summary looks #9065

Conversation

daveleek
Copy link
Contributor

@daveleek daveleek commented Jan 8, 2025

Removes the darker background when the milestone name input is present and focused.
Clicking inside the milestone name input doesn't trigger the accordion.
Sizing tweaks to prevent content jumping around when editing milestone name

Verified

This commit was signed with the committer’s verified signature.
saig0 Philipp Ossler
Copy link

vercel bot commented Jan 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 8:39am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Jan 8, 2025 8:39am

Copy link
Contributor

github-actions bot commented Jan 8, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

[theme.breakpoints.down(400)]: {
padding: theme.spacing(1, 2),
},
'&.Mui-focusVisible': {
backgroundColor: theme.palette.background.paper,
padding: theme.spacing(0.5, 2, 0.3, 2),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, 0.3 looks weird and doesn't resolve to # of pixels properly. But for some reason this stops the size rendering from jumping around. I'll look for a better solution

Copy link
Contributor

@gastonfournier gastonfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair to try!

@daveleek daveleek merged commit 55f7de0 into main Jan 8, 2025
13 checks passed
@daveleek daveleek deleted the chore/release-plan-template-creation-milestone-accordion-tweaks branch January 8, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants