feat: grouping of project level roles in autocomplete #9046
+96
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
kwasniew
commented
Dec 31, 2024
| ); | ||
|
|
||
| const sortedRoles = sortItems(roles); |
There was a problem hiding this comment.
project roles before custom roles and alphabetic sorting of custom roles
kwasniew
commented
Dec 31, 2024
| multiple | ||
| disableCloseOnSelect | ||
| openOnFocus | ||
| size='small' | ||
| value={value} | ||
| groupBy={(option) => { |
There was a problem hiding this comment.
built-in grouping and styling from MUI component
kwasniew
commented
Dec 31, 2024
| return ( | ||
| <> | ||
| <Autocomplete | ||
| slotProps={{ |
There was a problem hiding this comment.
override default list item styling to align to the top and remove left spacing
kwasniew
commented
Dec 31, 2024
| @@ -13,6 +13,7 @@ import { RoleDescription } from '../RoleDescription/RoleDescription'; | |||
| import { ConditionallyRender } from '../ConditionallyRender/ConditionallyRender'; | |||
|
|
|||
| const StyledRoleOption = styled('div')(({ theme }) => ({ | |||
| paddingTop: theme.spacing(0.75), | |||
There was a problem hiding this comment.
minor alignment tweak
kwasniew
requested review from
Tymek,
FredrikOseberg,
sjaanus and
thomasheartman
sjaanus
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Details:
Important files
Discussion points