Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: new hosted auth handler #9045

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

nunogois
Copy link
Member

@nunogois nunogois commented Dec 30, 2024

https://linear.app/unleash/issue/2-3074/add-sign-in-with-google-to-our-hosted-instances-when-only-password-is
https://linear.app/unleash/issue/2-3078/allow-viewer-access-from-auth-app-for-payg

Adds support for a new unified hosted auth handler.

This new auth handler provides a Google sign in option in case you don't have an SSO provider configured. It also provides a way for auth-app to sign in with Unleash's read-only user for Pro and Enterprise PAYG instances.

Check the PR comments for more details.

Copy link

vercel bot commented Dec 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 30, 2024 3:54pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Dec 30, 2024 3:54pm

Copy link
Contributor

github-actions bot commented Dec 30, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

label: 'SCIM',
component: <ScimSettings />,
});
}
Copy link
Member Author

@nunogois nunogois Dec 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need some guidance here.

Isn't SSO an Enterprise-only feature anyways?

AFAIK there's no way to get authenticationType === 'enterprise' in a hosted Pro instance. A Pro instance would simply display "Your Unleash instance is managed by the Unleash team." and not allow you to configure SSO. Am I missing something?

This PR simplifies our logic to rely on the plan instead of the auth type and protect SSO configuration behind the Enterprise plan.

If we're okay with this, then maybe we should protect the route from showing up at all for non-Enterprise plans on a follow-up PR.

Copy link
Contributor

@daveleek daveleek Jan 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is an improvement indeed, there used to be a flag there that got removed, and the isEnterprise check stayed behind.

Verified

This commit was signed with the committer’s verified signature.
nunogois Nuno Góis
Copy link
Contributor

@daveleek daveleek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks like an improvement!

@nunogois nunogois requested a review from paulaguijarro January 8, 2025 09:29
@nunogois nunogois merged commit e726947 into main Jan 8, 2025
12 checks passed
@nunogois nunogois deleted the chore-new-hosted-auth-handler branch January 8, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants