Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test inline mypy configuration with more stable mypy option #138

Merged
merged 2 commits into from Feb 25, 2024

Conversation

antecrescent
Copy link
Contributor

The mypy configuration --no-strict-optional is discouraged and not much tested. It caused the test to fail with >=mypy-1.6.0.

Closes #137

The mypy configuration --no-strict-optional is discouraged and not much
tested. It caused the test to fail with >=mypy-1.6.0.

Closes typeddjango#137
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please fix lint CI job? 🙏

@antecrescent
Copy link
Contributor Author

@sobolevn I hope the last commit is correct. I figured that if anything, it should be pytest, that generates (per-file) junit-xml output.

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sobolevn sobolevn merged commit 97aff1e into typeddjango:master Feb 25, 2024
9 checks passed
@sobolevn sobolevn mentioned this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Adjust test-mypy-config.yml to test with more stable mypy options
2 participants