New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1294 #1313
Fix #1294 #1313
Conversation
@@ -61,6 +61,9 @@ export class DynamicModulePlugin extends ConverterComponent { | |||
name = name.replace(/"/g, ''); | |||
this.reflections.push(reflection); | |||
this.basePath.add(name); | |||
if (context.getCompilerOptions().baseUrl) { | |||
this.basePath.add(context.getCompilerOptions().baseUrl as string + '/file'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed because BasePath
expects a file and then get the dirname, turning a/b/c
into a/b
this counteracts that.
Any updates? |
Can we add the baseUrl in |
Done! |
Can we do that for the SourcePlugin as well? |
|
Makes sense, thanks! Putting together a release now. |
Fixes #1294