Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement fallible deserialization #2

Closed
Toromyx opened this issue Oct 5, 2023 · 1 comment · Fixed by #6
Closed

Implement fallible deserialization #2

Toromyx opened this issue Oct 5, 2023 · 1 comment · Fixed by #6
Assignees
@Toromyx

Comments

@Toromyx
Copy link
Owner

Toromyx commented Oct 5, 2023

Sometimes data providers provide data which does not adhere 100% to the schema.

Currently serde completely fails to deserialize such data, even if the majority is usable. Think of and implement a way to work around this:
@Toromyx Toromyx self-assigned this Oct 15, 2023
@Toromyx
Copy link
Owner Author

Toromyx commented Oct 28, 2023

This is currently blocked by serde-rs/serde#1587 because I don't want to re-implement the derivation of Deserialize so that i can have a custom deserialization for each class schema.

Toromyx added a commit that referenced this issue Oct 30, 2023
@Toromyx
feat(#2): implement (theoretical) fallible deserialization
e270edc
Toromyx added a commit that referenced this issue Nov 8, 2023
@Toromyx
feat(#2): implement (practical) fallible deserialization
844e611
@Toromyx Toromyx linked a pull request Nov 8, 2023 that will close this issue
Implement fallible deserialization #6
Merged
@Toromyx Toromyx closed this as completed in #6 Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Toromyx Toromyx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement fallible deserialization Toromyx/schema_org_types_rs
1 participant
@Toromyx