Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread created by NamedThreadFactory should be a daemon #1390

Closed
z1c0 opened this issue Feb 2, 2024 · 2 comments · Fixed by #1391
Closed

Thread created by NamedThreadFactory should be a daemon #1390

z1c0 opened this issue Feb 2, 2024 · 2 comments · Fixed by #1391

Comments

@z1c0
Copy link

z1c0 commented Feb 2, 2024

In src/main/java/org/java_websocket/util/NamedThreadFactory.java, when a new Thread gets created, it should be marked as a background thread.

thread.setDaemon(true);

I'm using this library in a context where I have no control over shutdown (I get no callback or notification) and this thread is preventing proper shutdown.

@PhilipRoman
Copy link
Collaborator

Looks like we already have open PR #1201 for this. I will review it when I have time and most likely merge.

@z1c0
Copy link
Author

z1c0 commented Feb 2, 2024

Great news! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants