Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove nette/utils to allow easier install #86

Merged
merged 2 commits into from
Jul 31, 2023
Merged

Remove nette/utils to allow easier install #86

merged 2 commits into from
Jul 31, 2023

Conversation

TomasVotruba
Copy link
Owner

  • make use of preg_match_all()
  • use Arrays::flatten() locally

@TomasVotruba TomasVotruba force-pushed the tv-open-php branch 2 times, most recently from 98425fe to 3ddf340 Compare July 31, 2023 15:02
@TomasVotruba TomasVotruba changed the title tv open php Remove nette/utils to allow easier install Jul 31, 2023
@TomasVotruba TomasVotruba force-pushed the tv-open-php branch 2 times, most recently from 4df9661 to 56ad38d Compare July 31, 2023 15:05
@TomasVotruba TomasVotruba merged commit 29eda07 into main Jul 31, 2023
8 checks passed
staabm
staabm reviewed Jul 31, 2023
View reviewed changes
build/composer-php-72.json
"phpstan/phpstan": "^1.10.19",
"nette/utils": "^3.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great move to drop the dependency

@LeoVie
Copy link
Contributor

LeoVie commented Aug 4, 2023

Hi, in \TomasVotruba\UnusedPublic\CollectorMapper\MethodCallCollectorMapper there is a use Nette\Utils\Arrays; left. I think, this should get removed, too, right?

@TomasVotruba
Copy link
Owner Author

@LeoVie Hi, yes, great catch! Could you send PR to remove it please?

@LeoVie
Copy link
Contributor

LeoVie commented Aug 4, 2023

Sure.

@LeoVie
Copy link
Contributor

LeoVie commented Aug 4, 2023

Is there a reason for nette/utils being still existent in composer.json?

@TomasVotruba
Copy link
Owner Author

Not really, should be removed too

@LeoVie LeoVie mentioned this pull request Aug 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staabm staabm staabm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TomasVotruba @LeoVie @staabm