Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test installation on PHP 8.2/8.3 #82

Merged
merged 3 commits into from
Jul 30, 2023
Merged

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Jul 30, 2023

No description provided.

@staabm staabm marked this pull request as ready for review July 30, 2023 09:34
@@ -16,6 +16,8 @@ jobs:
- 7.2
- 8.0
- 8.1
- 8.2
- 8.3
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nette/utils does not yet support 8.3: nette/utils#297

@staabm staabm marked this pull request as draft July 30, 2023 09:54
@TomasVotruba TomasVotruba marked this pull request as ready for review July 30, 2023 10:50
@staabm
Copy link
Contributor Author

staabm commented Jul 30, 2023

@TomasVotruba locally tested with todays nette/utils 4.0.1 release. the testsuite is green.

composer.json Outdated
@@ -7,7 +7,7 @@
"require": {
"php": "^8.1",
"phpstan/phpstan": "^1.10.26",
"nette/utils": "^3.2",
"nette/utils": "^3.2 || ^4.0",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be needed for downgraded install. It must pass without any package dependencies.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh good point.

Copy link
Contributor Author

@staabm staabm Jul 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm but composer might not let you install the package because it cannot resolve dependencies..?
nette/utils declares php 8.3 compat as of 4.0.1. there is not php 8.3 compatible nette/utils 3.x release

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should not happen.
Could you provide falling CI job? I'll check it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. It works in CI .. not sure why it didn‘t locally

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Composer sometimes get glitches with these non-standard tagging :)

The best way is to remove composer.lock and /vendor.

@TomasVotruba TomasVotruba merged commit 4095bcb into TomasVotruba:main Jul 30, 2023
8 checks passed
@staabm staabm deleted the patch-1 branch July 31, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants