Take calls from plain php files into account #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Jul 25, 2023
| yield [[ | ||
| __DIR__ . '/Fixture/Tests/MethodForTests.php', | ||
| __DIR__ . '/Fixture/Tests/SkipCalledInTests.php', | ||
| ], [[$errorMessage, 13, RuleTips::SOLUTION_MESSAGE]]]; |
There was a problem hiding this comment.
I think this test was wrong before and reporting 2 errors is correct, as the only calls are in Test-classes
samsonasik
approved these changes
Jul 26, 2023
|
ping @TomasVotruba would be great to get this false positives out of the way. please also see the 2 other PRs |
staabm
commented
Jul 28, 2023
| @@ -50,13 +50,10 @@ public function processNode(Node $node, Scope $scope): ?array | |||
| return null; | |||
| } | |||
|
|
|||
| $classReflection = $scope->getClassReflection(); | |||
| if (! $classReflection instanceof ClassReflection) { | |||
There was a problem hiding this comment.
before this PR, this check made collection on code which is not within class-scope early exiting.
|
@TomasVotruba if you could merge this one and tag a new release, we would have fixed a major source of false postives with this lib 🤘 |
|
Let's ship this :) thank you 👏 |
|
thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.