Skip to content

Commit dc120df

Browse files
authoredOct 28, 2024··
refactor(types): less strict callbacks return type (#289)
1 parent b15ef8d commit dc120df

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed
 

‎packages/next-safe-action/src/action-builder.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,7 @@ export function actionBuilder<
289289
// Execute middleware chain + action function.
290290
await executeMiddlewareStack();
291291

292-
const callbacksToExecute: MaybePromise<void>[] = [];
292+
const callbacksToExecute: MaybePromise<unknown>[] = [];
293293

294294
// If an internal framework error occurred, throw it, so it will be processed by Next.js.
295295
if (frameworkError) {

‎packages/next-safe-action/src/hooks.types.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -27,16 +27,16 @@ export type HookCallbacks<
2727
CBAVE,
2828
Data,
2929
> = {
30-
onExecute?: (args: { input: S extends Schema ? InferIn<S> : undefined }) => MaybePromise<void>;
31-
onSuccess?: (args: { data?: Data; input: S extends Schema ? InferIn<S> : undefined }) => MaybePromise<void>;
30+
onExecute?: (args: { input: S extends Schema ? InferIn<S> : undefined }) => MaybePromise<unknown>;
31+
onSuccess?: (args: { data?: Data; input: S extends Schema ? InferIn<S> : undefined }) => MaybePromise<unknown>;
3232
onError?: (args: {
3333
error: Prettify<Omit<SafeActionResult<ServerError, S, BAS, CVE, CBAVE, Data>, "data">>;
3434
input: S extends Schema ? InferIn<S> : undefined;
35-
}) => MaybePromise<void>;
35+
}) => MaybePromise<unknown>;
3636
onSettled?: (args: {
3737
result: Prettify<SafeActionResult<ServerError, S, BAS, CVE, CBAVE, Data>>;
3838
input: S extends Schema ? InferIn<S> : undefined;
39-
}) => MaybePromise<void>;
39+
}) => MaybePromise<unknown>;
4040
};
4141

4242
/**

‎packages/next-safe-action/src/index.types.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -175,14 +175,14 @@ export type SafeActionUtils<
175175
bindArgsParsedInputs: InferArray<BAS>;
176176
hasRedirected: boolean;
177177
hasNotFound: boolean;
178-
}) => MaybePromise<void>;
178+
}) => MaybePromise<unknown>;
179179
onError?: (args: {
180180
error: Prettify<Omit<SafeActionResult<ServerError, S, BAS, CVE, CBAVE, Data>, "data">>;
181181
metadata: MD;
182182
ctx?: Prettify<Ctx>;
183183
clientInput: S extends Schema ? InferIn<S> : undefined;
184184
bindArgsClientInputs: InferInArray<BAS>;
185-
}) => MaybePromise<void>;
185+
}) => MaybePromise<unknown>;
186186
onSettled?: (args: {
187187
result: Prettify<SafeActionResult<ServerError, S, BAS, CVE, CBAVE, Data>>;
188188
metadata: MD;
@@ -191,7 +191,7 @@ export type SafeActionUtils<
191191
bindArgsClientInputs: InferInArray<BAS>;
192192
hasRedirected: boolean;
193193
hasNotFound: boolean;
194-
}) => MaybePromise<void>;
194+
}) => MaybePromise<unknown>;
195195
};
196196

197197
/**

0 commit comments

Comments
 (0)
Please sign in to comment.