fix(border): fix flipped title colors in panel border #5553
Conversation
Revert the change to the color flipping logic for `panel` border titles. The issue with the new method using `Style(reverse=True)` is that this will also flip any border title colors set with Textual CSS. Fixes Textualize#5548.
| ( | ||
| (base_label_background + label_color) | ||
| if label_color.a | ||
| else TRANSPARENT | ||
| ), |
There was a problem hiding this comment.
This change effectively reverts to the original logic, which is necessary since the foreground/background is flipped for the panel border.
I wanted to flag this change in case there is something I've missed. While this did cause a couple of snapshot tests to fail, visually they looked identical.
There was a problem hiding this comment.
It's encouraging that no tests broke
The previous version added the border color, this version doesn't. I don't recall what, if anything, that was there for. I have a suspicion it is something to do with transparent borders. i.e. if the border color has alpha.
There was a problem hiding this comment.
Thanks for checking, I wasn't sure what the border color was there for either.
If the border title actually only sits on the border color for the panel/tab styles, maybe this isn't needed....?
There was a problem hiding this comment.
Wish I could go back in time and ask myself why I did that. If I didn't write a test for it, then it's probably safe.
| ( | ||
| (base_label_background + label_color) | ||
| if label_color.a | ||
| else TRANSPARENT | ||
| ), |
There was a problem hiding this comment.
It's encouraging that no tests broke
The previous version added the border color, this version doesn't. I don't recall what, if anything, that was there for. I have a suspicion it is something to do with transparent borders. i.e. if the border color has alpha.
|
Thanks |
TomJGooding
deleted the
fix-border-fix-flipped-title-colors-in-panel-border
branch
Revert the change to the color flipping logic for
panelborder titles.The issue with the new method using
Style(reverse=True)is that this will also flip any border title colors set with Textual CSS.Fixes #5548.
Please review the following checklist.