Fix Tameable protections #2131
Merged
Fix Tameable protections #2131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually a bit messier than I thought, realized while testing something else that the fallthrough to default causes non-wolf pets to always be protected outside of claims. This does fix cases where animals should be protected but aren't, but it doesn't fix some cases where they shouldn't be. Going to end up with some duplicate lines unfortunately, but there's not a lot that can be done about that without mixing a bunch of PVP logic into non-PVP code. |
|
Closes #1679 /e: Oh, I guess that doesn't update the linked issues, gotta edit OP |
RoboMWM
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2128
Closes #1679