Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve UUID strings when matching players #2045

Merged
merged 4 commits into from
May 3, 2023

Conversation

Jikoo
Copy link
Collaborator

@Jikoo Jikoo commented Apr 21, 2023

Allows commands such as /trust to target arbitrary UUIDs. Not a frequent thing, but improves mod support without requiring an addon. Addon would still be better UX, i.e. /modtrust build create or similar instead of /trust <uuid of Create fake player>, but it would at least allow GP to function to some degree for advanced users. Servers could also set up a /trustmodname in their commands.yml:

aliases:
  trustmodname:
  - "trust <mod fake player UUID>"

Also allows targeting offline players via commands more reliably, i.e. a player data cleanup system might run commands from several plugins during an inactivity purge. /deleteallclaims John_Minecraft fails if John_Minecraft has not logged in since server restart, but /deleteallclaims <John_Minecraft's uuid> would succeed after this PR.
The only current case where UUID targeting is allowed is /adjustbonusclaimblocks

The only command blocked from arbitrary UUID execution is /givepet because it would allow users to give pets to nonexistent players, creating a mess that would require admin intervention.

Closes #1305
Closes #1586
/e: also #1970

@RoboMWM RoboMWM merged commit e5f579d into GriefPrevention:master May 3, 2023
1 check passed
@Jikoo Jikoo deleted the dev/trust-uuids branch May 3, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants