Candles require full trust, remove duplicate candle cake handling #1827
+4
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh I can't read. Candles also shouldn't be in that category. Brb fixing. |
Jikoo
changed the title
RoboMWM
approved these changes
Mar 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Candle cakes were already handled and were erroneously added to containertrust. It made sense to match candles requiring container trust, but it's more accurate to match the underlying cake. Honestly, candles are used for decor, making them only require containertrust to modify makes them unusable in shop areas. Why did we make candles a container level thing at all? IMO they should be full trust just like armor stands.
Addresses #1560 (comment)