Skip to content

Commit 8470857

Browse files
authoredFeb 7, 2025··
fix: register scrollend event when useScrollendEvent (#922)
1 parent 5151ee4 commit 8470857

File tree

1 file changed

+16
-6
lines changed

1 file changed

+16
-6
lines changed
 

‎packages/virtual-core/src/index.ts

+16-6
Original file line numberDiff line numberDiff line change
@@ -170,11 +170,16 @@ export const observeElementOffset = <T extends Element>(
170170
endHandler()
171171

172172
element.addEventListener('scroll', handler, addEventListenerOptions)
173-
element.addEventListener('scrollend', endHandler, addEventListenerOptions)
174-
173+
const registerScrollendEvent =
174+
instance.options.useScrollendEvent && supportsScrollend
175+
if (registerScrollendEvent) {
176+
element.addEventListener('scrollend', endHandler, addEventListenerOptions)
177+
}
175178
return () => {
176179
element.removeEventListener('scroll', handler)
177-
element.removeEventListener('scrollend', endHandler)
180+
if (registerScrollendEvent) {
181+
element.removeEventListener('scrollend', endHandler)
182+
}
178183
}
179184
}
180185

@@ -213,11 +218,16 @@ export const observeWindowOffset = (
213218
endHandler()
214219

215220
element.addEventListener('scroll', handler, addEventListenerOptions)
216-
element.addEventListener('scrollend', endHandler, addEventListenerOptions)
217-
221+
const registerScrollendEvent =
222+
instance.options.useScrollendEvent && supportsScrollend
223+
if (registerScrollendEvent) {
224+
element.addEventListener('scrollend', endHandler, addEventListenerOptions)
225+
}
218226
return () => {
219227
element.removeEventListener('scroll', handler)
220-
element.removeEventListener('scrollend', endHandler)
228+
if (registerScrollendEvent) {
229+
element.removeEventListener('scrollend', endHandler)
230+
}
221231
}
222232
}
223233

0 commit comments

Comments
 (0)
Please sign in to comment.