refactor(router-core): moving internals of Router to router core #3800
+2,601
−5,206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit 9487084.
☁️ Nx Cloud last updated this comment at |
More templates
@tanstack/arktype-adapter
@tanstack/create-router
@tanstack/directive-functions-plugin
@tanstack/eslint-plugin-router
@tanstack/create-start
@tanstack/history
@tanstack/react-router
@tanstack/react-router-devtools
@tanstack/react-router-with-query
@tanstack/react-start
@tanstack/react-start-client
@tanstack/react-start-config
@tanstack/react-start-plugin
@tanstack/react-start-router-manifest
@tanstack/react-start-server
@tanstack/router-cli
@tanstack/router-core
@tanstack/router-devtools
@tanstack/router-devtools-core
@tanstack/router-generator
@tanstack/router-plugin
@tanstack/router-utils
@tanstack/router-vite-plugin
@tanstack/server-functions-plugin
@tanstack/solid-router
@tanstack/solid-router-devtools
@tanstack/solid-start
@tanstack/solid-start-client
@tanstack/solid-start-config
@tanstack/solid-start-plugin
@tanstack/solid-start-router-manifest
@tanstack/solid-start-server
@tanstack/start
@tanstack/start-api-routes
@tanstack/start-client-core
@tanstack/start-config
@tanstack/start-server-core
@tanstack/start-server-functions-client
@tanstack/start-server-functions-fetcher
@tanstack/start-server-functions-handler
@tanstack/start-server-functions-server
@tanstack/start-server-functions-ssr
@tanstack/valibot-adapter
@tanstack/virtual-file-routes
@tanstack/zod-adapter
commit: |
birkskyum
added a commit
that referenced
this pull request
Mar 18, 2025
Similar to #3800 , this use base classes to contain shared methods of the solid/react-router Route in the router-core package.
birkskyum
force-pushed
the
move-most-of-router-to-router-core
branch
from
975bd31 to
1d8286c
Compare
birkskyum
force-pushed
the
move-most-of-router-to-router-core
branch
from
1d8286c to
efe78f0
Compare
|
There is a challenge here. The Link component lose it's type inference, for instance on the onClick event of e2e/react-start/basic/src/components/DefaultCatchBoundary.tsx, because it can't tell any longer it's in a react context. We have to explicit type it |
|
@chorobin , it's only types that are failing here. If I added the types in the user code e2e/example, then it works fine. would you be able to help debug how we can make the react-router Link have react types again? |
Unfortunately |
chorobin
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The router-core has a new RouterCore class, that the frameworks' Router class just extend
If there were framework specific methods on the Router, it would be trivial to overwrite those this way
This reduces the size of the adapter packages by a third (e.g. packages/react-router/src from ~7000 -> 4311 LOC)