Skip to content

Commit 27b0283

Browse files
authoredMar 18, 2025··
refactor(router-core): moving internals of Router to router core (#3800)
1 parent 4190c07 commit 27b0283

File tree

12 files changed

+2601
-5206
lines changed

12 files changed

+2601
-5206
lines changed
 

Diff for: ‎packages/react-router/src/index.tsx

+3-3
Original file line numberDiff line numberDiff line change
@@ -285,15 +285,15 @@ export type {
285285
NotFoundRouteComponent,
286286
} from './route'
287287

288+
export { createRouter, Router } from './router'
289+
288290
export {
289291
componentTypes,
290-
createRouter,
291-
Router,
292292
lazyFn,
293293
SearchParamError,
294294
PathParamError,
295295
getInitialRouterState,
296-
} from './router'
296+
} from '@tanstack/router-core'
297297

298298
export { RouterProvider, RouterContextProvider } from './RouterProvider'
299299
export type { RouterProps } from './RouterProvider'

Diff for: ‎packages/react-router/src/route.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ import type {
3030
RouteMask,
3131
RouteOptions,
3232
RouteTypesById,
33-
Router,
33+
RouterCore,
3434
ToMaskOptions,
3535
UseNavigateResult,
3636
} from '@tanstack/router-core'
@@ -469,7 +469,7 @@ export function createRouteMask<
469469
>(
470470
opts: {
471471
routeTree: TRouteTree
472-
} & ToMaskOptions<Router<TRouteTree, 'never', boolean>, TFrom, TTo>,
472+
} & ToMaskOptions<RouterCore<TRouteTree, 'never', boolean>, TFrom, TTo>,
473473
): RouteMask<TRouteTree> {
474474
return opts as any
475475
}

Diff for: ‎packages/react-router/src/router.ts

+14-2,535
Large diffs are not rendered by default.

Diff for: ‎packages/react-router/src/routerContext.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
import * as React from 'react'
2-
import type { AnyRouter, Router } from '@tanstack/router-core'
2+
import type { AnyRouter } from '@tanstack/router-core'
33

44
declare global {
55
interface Window {
66
__TSR_ROUTER_CONTEXT__?: React.Context<AnyRouter>
77
}
88
}
99

10-
const routerContext = React.createContext<Router<any, any, any>>(null!)
10+
const routerContext = React.createContext<AnyRouter>(null!)
1111

1212
export function getRouterContext() {
1313
if (typeof document === 'undefined') {

Diff for: ‎packages/router-core/package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@
6060
},
6161
"dependencies": {
6262
"@tanstack/history": "workspace:*",
63-
"@tanstack/store": "^0.7.0"
63+
"@tanstack/store": "^0.7.0",
64+
"tiny-invariant": "^1.3.3"
6465
}
6566
}

Diff for: ‎packages/router-core/src/history.ts

+9
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
import type { HistoryLocation } from '@tanstack/history'
2+
3+
declare module '@tanstack/history' {
4+
interface HistoryState {
5+
__tempLocation?: HistoryLocation
6+
__tempKey?: string
7+
__hashScrollIntoViewOptions?: boolean | ScrollIntoViewOptions
8+
}
9+
}

Diff for: ‎packages/router-core/src/index.ts

+11-2
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,16 @@ export type {
199199
RouteAddFileTypesFn,
200200
} from './route'
201201

202-
export { defaultSerializeError, getLocationChangeInfo } from './router'
202+
export {
203+
defaultSerializeError,
204+
getLocationChangeInfo,
205+
RouterCore,
206+
componentTypes,
207+
lazyFn,
208+
SearchParamError,
209+
PathParamError,
210+
getInitialRouterState,
211+
} from './router'
203212
export type {
204213
ViewTransitionOptions,
205214
ExtractedBaseEntry,
@@ -220,7 +229,6 @@ export type {
220229
RouterEvents,
221230
MatchRoutesOpts,
222231
RouterOptionsExtensions,
223-
Router,
224232
DefaultRemountDepsFn,
225233
PreloadRouteFn,
226234
MatchRouteFn,
@@ -246,6 +254,7 @@ export type {
246254
LoadRouteChunkFn,
247255
ServerSrr,
248256
ClearCacheFn,
257+
CreateRouterFn,
249258
} from './router'
250259

251260
export type {

Diff for: ‎packages/router-core/src/router.ts

+2,511-106
Large diffs are not rendered by default.

Diff for: ‎packages/solid-router/src/index.tsx

+3-3
Original file line numberDiff line numberDiff line change
@@ -293,15 +293,15 @@ export type {
293293
NotFoundRouteComponent,
294294
} from './route'
295295

296+
export { createRouter, Router } from './router'
297+
296298
export {
297299
componentTypes,
298-
createRouter,
299-
Router,
300300
lazyFn,
301301
SearchParamError,
302302
PathParamError,
303303
getInitialRouterState,
304-
} from './router'
304+
} from '@tanstack/router-core'
305305

306306
export { RouterProvider, RouterContextProvider } from './RouterProvider'
307307
export type { RouterProps } from './RouterProvider'

Diff for: ‎packages/solid-router/src/route.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ import type {
3030
RouteMask,
3131
RouteOptions,
3232
RouteTypesById,
33-
Router,
33+
RouterCore,
3434
ToMaskOptions,
3535
UseNavigateResult,
3636
} from '@tanstack/router-core'
@@ -420,7 +420,7 @@ export function createRouteMask<
420420
>(
421421
opts: {
422422
routeTree: TRouteTree
423-
} & ToMaskOptions<Router<TRouteTree, 'never', false>, TFrom, TTo>,
423+
} & ToMaskOptions<RouterCore<TRouteTree, 'never', false>, TFrom, TTo>,
424424
): RouteMask<TRouteTree> {
425425
return opts as any
426426
}

Diff for: ‎packages/solid-router/src/router.ts

+39-2,550
Large diffs are not rendered by default.

Diff for: ‎pnpm-lock.yaml

+3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)
Please sign in to comment.