refactor(query-core): remove double negative #8952
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit a247429.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8952 +/- ##
===========================================
+ Coverage 44.09% 55.93% +11.83%
===========================================
Files 201 116 -85
Lines 8025 5006 -3019
Branches 1759 1302 -457
===========================================
- Hits 3539 2800 -739
+ Misses 4058 1914 -2144
+ Partials 428 292 -136 🚀 New features to boost your workflow:
|
TkDodo
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the partialMatchKey function to improve readability by replacing a double negation with the more intuitive every() method. This change makes the logic easier to understand at a glance, as it clearly expresses that all keys in object b must match corresponding keys in object a.