test(react-query): fix async to promise and remove unnecessary await to match TypeScript requirements in useQueries.test.tsx #8887

minseong0324 · 2025-03-30T17:56:49Z

Fix ESLint warnings for async functions without await

Resolved ESLint "require-await" warnings throughout the test files by:

Removing unnecessary async keywords where no await is used
Using Promise.resolve() to explicitly return promises instead

These changes don't affect functionality but make the linter happy and improve code clarity.

nx-cloud · 2025-03-30T17:57:12Z

View your CI Pipeline Execution ↗ for commit 24532de.

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	5m 6s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	33s	View ↗

☁️ Nx Cloud last updated this comment at 2025-03-30 19:48:09 UTC

pkg-pr-new · 2025-03-30T18:00:23Z

Open in Stackblitz

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8887

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@8887

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@8887

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8887

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@8887

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@8887

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@8887

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@8887

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@8887

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@8887

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@8887

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@8887

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@8887

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@8887

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@8887

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@8887

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@8887

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@8887

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@8887

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@8887

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@8887

commit: 24532de

codecov · 2025-03-30T18:02:59Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.83%. Comparing base (cd6c8c0) to head (24532de).
Report is 6 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #8887       +/-   ##
===========================================
- Coverage   46.59%   32.83%   -13.76%     
===========================================
  Files         200        5      -195     
  Lines        7574       67     -7507     
  Branches     1743       16     -1727     
===========================================
- Hits         3529       22     -3507     
+ Misses       3669       37     -3632     
+ Partials      376        8      -368

Components	Coverage Δ
@tanstack/angular-query-devtools-experimental	`∅ <ø> (∅)`
@tanstack/angular-query-experimental	`∅ <ø> (∅)`
@tanstack/eslint-plugin-query	`∅ <ø> (∅)`
@tanstack/query-async-storage-persister	`∅ <ø> (∅)`
@tanstack/query-broadcast-client-experimental	`∅ <ø> (∅)`
@tanstack/query-codemods	`∅ <ø> (∅)`
@tanstack/query-core	`∅ <ø> (∅)`
@tanstack/query-devtools	`∅ <ø> (∅)`
@tanstack/query-persist-client-core	`∅ <ø> (∅)`
@tanstack/query-sync-storage-persister	`∅ <ø> (∅)`
@tanstack/react-query	`∅ <ø> (∅)`
@tanstack/react-query-devtools	`10.00% <ø> (ø)`
@tanstack/react-query-next-experimental	`∅ <ø> (∅)`
@tanstack/react-query-persist-client	`100.00% <ø> (ø)`
@tanstack/solid-query	`∅ <ø> (∅)`
@tanstack/solid-query-devtools	`∅ <ø> (∅)`
@tanstack/solid-query-persist-client	`∅ <ø> (∅)`
@tanstack/svelte-query	`∅ <ø> (∅)`
@tanstack/svelte-query-devtools	`∅ <ø> (∅)`
@tanstack/svelte-query-persist-client	`∅ <ø> (∅)`
@tanstack/vue-query	`∅ <ø> (∅)`
@tanstack/vue-query-devtools	`∅ <ø> (∅)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

TkDodo · 2025-03-31T08:27:39Z

can we make the lint rule an error after all these are fixed please?

minseong0324 · 2025-03-31T17:33:19Z

can we make the lint rule an error after all these are fixed please?

Should I apply the line rule to the react-query package first after all this related work is done?

If all the async related work is done for the react-query package, I'm going to continue with the query-core. @TkDodo

fix(react-query): fix async to promise and remove unnecessary await

Loading
Loading status checks…

a64679a

github-actions bot added the package: react-query label Mar 30, 2025

minseong0324 changed the title ~~fix(react-query): fix async to promise and remove unnecessary await~~ fix(react-query): fix async to promise and remove unnecessary await in useQueries.test.tsx Mar 30, 2025

minseong0324 force-pushed the test/fix-and-remove-unnecessary-async branch from d368e6b to a64679a Compare March 30, 2025 18:09

minseong0324 changed the title ~~fix(react-query): fix async to promise and remove unnecessary await in useQueries.test.tsx~~ test(react-query): fix async to promise and remove unnecessary await in useQueries.test.tsx Mar 30, 2025

minseong0324 changed the title ~~test(react-query): fix async to promise and remove unnecessary await in useQueries.test.tsx~~ test(react-query): fix async to promise and remove unnecessary await to match TypeScript requirements in useQueries.test.tsx Mar 30, 2025

Merge branch 'main' into test/fix-and-remove-unnecessary-async

Loading
Loading status checks…

24532de

TkDodo merged commit 517c490 into TanStack:main Mar 31, 2025
5 of 7 checks passed

minseong0324 mentioned this pull request Mar 31, 2025

chore(query-devtools): add @typescript-eslint/require-await for notice error for query-devtools package #8918

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GitHub Sponsors

test(react-query): fix async to promise and remove unnecessary await to match TypeScript requirements in useQueries.test.tsx #8887

test(react-query): fix async to promise and remove unnecessary await to match TypeScript requirements in useQueries.test.tsx #8887

minseong0324 commented Mar 30, 2025

nx-cloud bot commented Mar 30, 2025 •

edited

Loading

pkg-pr-new bot commented Mar 30, 2025 •

edited

Loading

codecov bot commented Mar 30, 2025 •

edited

Loading

TkDodo commented Mar 31, 2025

minseong0324 commented Mar 31, 2025 •

edited

Loading

test(react-query): fix async to promise and remove unnecessary await to match TypeScript requirements in useQueries.test.tsx #8887

test(react-query): fix async to promise and remove unnecessary await to match TypeScript requirements in useQueries.test.tsx #8887

Conversation

minseong0324 commented Mar 30, 2025

nx-cloud bot commented Mar 30, 2025 • edited Loading

pkg-pr-new bot commented Mar 30, 2025 • edited Loading

codecov bot commented Mar 30, 2025 • edited Loading

Codecov Report

TkDodo commented Mar 31, 2025

minseong0324 commented Mar 31, 2025 • edited Loading

nx-cloud bot commented Mar 30, 2025 •

edited

Loading

pkg-pr-new bot commented Mar 30, 2025 •

edited

Loading

codecov bot commented Mar 30, 2025 •

edited

Loading

minseong0324 commented Mar 31, 2025 •

edited

Loading