Fix issues with queryOptions factory method types #8394
Merged
+124
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 3b26d75. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Nick-Lucas
commented
Dec 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8394 +/- ##
===========================================
+ Coverage 46.21% 63.03% +16.81%
===========================================
Files 198 134 -64
Lines 7509 4804 -2705
Branches 1710 1345 -365
===========================================
- Hits 3470 3028 -442
+ Misses 3664 1536 -2128
+ Partials 375 240 -135 |
can you try the PR preview builds? |
TkDodo
requested changes
Dec 4, 2024
3 tasks
Thanks, that's a life-safer, the content of this PR has tRPC's codebase passing now (trpc/trpc#6290) albeit with one fix for correctness related to the DataTag change: |
Nick-Lucas
commented
Dec 4, 2024
Nick-Lucas
added a commit
to trpc/trpc
that referenced
this pull request
Dec 4, 2024
Nick-Lucas
added a commit
to trpc/trpc
that referenced
this pull request
Dec 4, 2024
Nick-Lucas
force-pushed
the
fixing-type-issues
branch
from
1030e64 to
2cc0950
Compare
TkDodo
reviewed
Dec 7, 2024
packages/angular-query-experimental/src/infinite-query-options.ts
Outdated
Show resolved
Hide resolved
Nick-Lucas
force-pushed
the
fixing-type-issues
branch
from
2cc0950 to
0d57717
Compare
Nick-Lucas
force-pushed
the
fixing-type-issues
branch
3 times, most recently
from
9beffc5 to
1f7d0b2
Compare
Nick-Lucas
commented
Dec 11, 2024
Nick-Lucas
force-pushed
the
fixing-type-issues
branch
from
d0151ee to
bc8908d
Compare
Nick-Lucas
force-pushed
the
fixing-type-issues
branch
from
bc8908d to
e464740
Compare
TkDodo
approved these changes
Dec 17, 2024
juliusmarminge
added a commit
to trpc/trpc
that referenced
this pull request
Feb 17, 2025
* create a standalone package for queryOptoins API * revert * fix import * add useSuspenseQuery * fix * move types * move again * mutationOptions * rm use * add subscriptions * imports * nice * consistent function definitions * react context provider * rename * move * add tsc tester * fix example * make nicer hover * rm unused * add router init * rm includes * import * make hover even nicer * chore: apply lint and formatting fixes * Standalone queryoptions package polymorphism (#6244) Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * chore: apply lint and formatting fixes * sync lock * add mutation key * fmt * resource management * cleanup * tidy up rsc example * chore: apply lint and formatting fixes * handle infinite * add subscription connection state * fix the `observableToAsyncIterable` * tweak * start codemod * fix git checker * fix relative path * fix dev mode * fix build ocnfig * maybe? * cjs * configuring bin is hard... * maybe? * c? * stable now? * aight?? * okaay * readme * restructure tests and add more * letsss gooo * clean up * fix * fix suspense destructuring * sync lock * alpha.3 * alpha.4 * fix lockfile? * wip * wip * add some logging etc * wip * uninstall * addadd * wip * bump/align tanstack in lockfile * fail on no choice * Add DataTag for query key and QueryFilter type safety (#6265) * Add DataTag for query result * Playing with QueryFilter type safety * Add type tests for QueryFilters * Add filters to route type * Add another todo * Fix todos * Upgrade tanstack query and remove patched type for QueryFilters * Disable rule which is misbehaving * Support DataTag with Error type for Tanstack React Query against local build * Remove eslint change * Upgrade react query * Update peer deps * chore: apply lint and formatting fixes * Upgrade react-query to include fix PR * Fix some of the issues --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * Upgrade react query to preview build from TanStack/query#8394 * Upgrade to latest react query preview * Up rq * Bump react to 19 * Some fixes * chore: apply lint and formatting fixes * Fix types * Fix DataTag type reference issue * Add vitest spy for type annotation * Standalone queryoptions package portable fix (#6332) * Add portability bug * update lockfile * Upgrade to pr.new build * Revert infiniteQueryoptions as well * Upgrade again * Upgrade to latest * Change peer dep * bump to latest * format * bump 1 more rq * Update packages/tanstack-react-query/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * chore: apply lint and formatting fixes * cool * don't cross-import test * install ws * polyfill eventsource * forgot to save * whoops * merge * publish alphas * Adding docs and example project * Fix shiki by not using shiki * Add blog post * Fix * chore: apply lint and formatting fixes * Upgrade react query * Fix order mistake for providers * Remove redundant comment * undo greeting change * Fix typog * Tweaks to docs * chore: apply lint and formatting fixes * tweaks * lock * Break apart blog post a little and add dedicated migration guide * Add Why the change? * fix resource managament * simplify test * improve tests * fixes * tweak * fix * fix * tweak * rm only * more docs * aight * incude command * repub * chore: apply lint and formatting fixes * nits * nit * fix broken link * chore: apply lint and formatting fixes * typo fix * maybe fix!? * tweak docs * hmm * Update www/docs/client/tanstack-react-query/introduction.mdx Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * chore: apply lint and formatting fixes * fixy * fix nick’s bluesky * meep * re-add twoslash * tweaks * hello * tweak * fix lint-prune * fixxxtures * tweak * upstream * tweaks * split docs up * mkay * minimal react * try it out * maybe * maybe not * revert me on other pr * Revert "revert me on other pr" This reverts commit f4b969d. * revert me * Revert "revert me" This reverts commit d0cdf44. * revert * revert me * revert me * Revert "revert" This reverts commit ad8b1ef. * Revert "revert me" This reverts commit 2694f69. * Revert "revert me" This reverts commit 474e7e6. * lockfile * lockfile * tweak * fix: grab call expression deeper than 2 calls (#6489) Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: juliusmarminge <julius0216@outlook.com> * pub * pub * server component docs * chore: apply lint and formatting fixes * refactor: make walkers to follow Tail-call pattern (#6496) Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * appreciation mention * add callout that you don't have to use the integration * show non-context setup * typo * rm ctx * cool * nice * fix imports * nit * cool * callout * fmt * nit * avoid internal imports as much as possible * add some more jsdoc links * cool * nits * ignore codemod in codecov * change link * portability * cool * FC * sync versions * cool * date --------- Co-authored-by: KATT <alexander@n1s.se> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Nick Lucas <Nick-Lucas@users.noreply.github.com> Co-authored-by: Nick Lucas <me@nicklucas.co.uk> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: Siddharth Gelera (reaper) <sidgroks@gmail.com>
trpc-bot
pushed a commit
to trpc/examples-minimal-react
that referenced
this pull request
Feb 17, 2025
* create a standalone package for queryOptoins API * revert * fix import * add useSuspenseQuery * fix * move types * move again * mutationOptions * rm use * add subscriptions * imports * nice * consistent function definitions * react context provider * rename * move * add tsc tester * fix example * make nicer hover * rm unused * add router init * rm includes * import * make hover even nicer * chore: apply lint and formatting fixes * Standalone queryoptions package polymorphism (#6244) Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * chore: apply lint and formatting fixes * sync lock * add mutation key * fmt * resource management * cleanup * tidy up rsc example * chore: apply lint and formatting fixes * handle infinite * add subscription connection state * fix the `observableToAsyncIterable` * tweak * start codemod * fix git checker * fix relative path * fix dev mode * fix build ocnfig * maybe? * cjs * configuring bin is hard... * maybe? * c? * stable now? * aight?? * okaay * readme * restructure tests and add more * letsss gooo * clean up * fix * fix suspense destructuring * sync lock * alpha.3 * alpha.4 * fix lockfile? * wip * wip * add some logging etc * wip * uninstall * addadd * wip * bump/align tanstack in lockfile * fail on no choice * Add DataTag for query key and QueryFilter type safety (#6265) * Add DataTag for query result * Playing with QueryFilter type safety * Add type tests for QueryFilters * Add filters to route type * Add another todo * Fix todos * Upgrade tanstack query and remove patched type for QueryFilters * Disable rule which is misbehaving * Support DataTag with Error type for Tanstack React Query against local build * Remove eslint change * Upgrade react query * Update peer deps * chore: apply lint and formatting fixes * Upgrade react-query to include fix PR * Fix some of the issues --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * Upgrade react query to preview build from TanStack/query#8394 * Upgrade to latest react query preview * Up rq * Bump react to 19 * Some fixes * chore: apply lint and formatting fixes * Fix types * Fix DataTag type reference issue * Add vitest spy for type annotation * Standalone queryoptions package portable fix (#6332) * Add portability bug * update lockfile * Upgrade to pr.new build * Revert infiniteQueryoptions as well * Upgrade again * Upgrade to latest * Change peer dep * bump to latest * format * bump 1 more rq * Update packages/tanstack-react-query/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * chore: apply lint and formatting fixes * cool * don't cross-import test * install ws * polyfill eventsource * forgot to save * whoops * merge * publish alphas * Adding docs and example project * Fix shiki by not using shiki * Add blog post * Fix * chore: apply lint and formatting fixes * Upgrade react query * Fix order mistake for providers * Remove redundant comment * undo greeting change * Fix typog * Tweaks to docs * chore: apply lint and formatting fixes * tweaks * lock * Break apart blog post a little and add dedicated migration guide * Add Why the change? * fix resource managament * simplify test * improve tests * fixes * tweak * fix * fix * tweak * rm only * more docs * aight * incude command * repub * chore: apply lint and formatting fixes * nits * nit * fix broken link * chore: apply lint and formatting fixes * typo fix * maybe fix!? * tweak docs * hmm * Update www/docs/client/tanstack-react-query/introduction.mdx Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * chore: apply lint and formatting fixes * fixy * fix nick’s bluesky * meep * re-add twoslash * tweaks * hello * tweak * fix lint-prune * fixxxtures * tweak * upstream * tweaks * split docs up * mkay * minimal react * try it out * maybe * maybe not * revert me on other pr * Revert "revert me on other pr" This reverts commit f4b969d0033bf2f068a37e37066df570a279c582. * revert me * Revert "revert me" This reverts commit d0cdf4469974223df4c7fec0c434e4cb3b865180. * revert * revert me * revert me * Revert "revert" This reverts commit ad8b1ef7a0d4cee8cd81e95c38ec442cc264d1d4. * Revert "revert me" This reverts commit 2694f69e2b2fc6e599a2f15c14fed77a4fa7ef3a. * Revert "revert me" This reverts commit 474e7e673ce2ef0b016b313a634e40b6f9bf9ef3. * lockfile * lockfile * tweak * fix: grab call expression deeper than 2 calls (#6489) Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: juliusmarminge <julius0216@outlook.com> * pub * pub * server component docs * chore: apply lint and formatting fixes * refactor: make walkers to follow Tail-call pattern (#6496) Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * appreciation mention * add callout that you don't have to use the integration * show non-context setup * typo * rm ctx * cool * nice * fix imports * nit * cool * callout * fmt * nit * avoid internal imports as much as possible * add some more jsdoc links * cool * nits * ignore codemod in codecov * change link * portability * cool * FC * sync versions * cool * date --------- Co-authored-by: KATT <alexander@n1s.se> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Nick Lucas <Nick-Lucas@users.noreply.github.com> Co-authored-by: Nick Lucas <me@nicklucas.co.uk> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: Siddharth Gelera (reaper) <sidgroks@gmail.com>
trpc-bot
pushed a commit
to trpc/examples-next-app-dir
that referenced
this pull request
Feb 17, 2025
* create a standalone package for queryOptoins API * revert * fix import * add useSuspenseQuery * fix * move types * move again * mutationOptions * rm use * add subscriptions * imports * nice * consistent function definitions * react context provider * rename * move * add tsc tester * fix example * make nicer hover * rm unused * add router init * rm includes * import * make hover even nicer * chore: apply lint and formatting fixes * Standalone queryoptions package polymorphism (#6244) Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * chore: apply lint and formatting fixes * sync lock * add mutation key * fmt * resource management * cleanup * tidy up rsc example * chore: apply lint and formatting fixes * handle infinite * add subscription connection state * fix the `observableToAsyncIterable` * tweak * start codemod * fix git checker * fix relative path * fix dev mode * fix build ocnfig * maybe? * cjs * configuring bin is hard... * maybe? * c? * stable now? * aight?? * okaay * readme * restructure tests and add more * letsss gooo * clean up * fix * fix suspense destructuring * sync lock * alpha.3 * alpha.4 * fix lockfile? * wip * wip * add some logging etc * wip * uninstall * addadd * wip * bump/align tanstack in lockfile * fail on no choice * Add DataTag for query key and QueryFilter type safety (#6265) * Add DataTag for query result * Playing with QueryFilter type safety * Add type tests for QueryFilters * Add filters to route type * Add another todo * Fix todos * Upgrade tanstack query and remove patched type for QueryFilters * Disable rule which is misbehaving * Support DataTag with Error type for Tanstack React Query against local build * Remove eslint change * Upgrade react query * Update peer deps * chore: apply lint and formatting fixes * Upgrade react-query to include fix PR * Fix some of the issues --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * Upgrade react query to preview build from TanStack/query#8394 * Upgrade to latest react query preview * Up rq * Bump react to 19 * Some fixes * chore: apply lint and formatting fixes * Fix types * Fix DataTag type reference issue * Add vitest spy for type annotation * Standalone queryoptions package portable fix (#6332) * Add portability bug * update lockfile * Upgrade to pr.new build * Revert infiniteQueryoptions as well * Upgrade again * Upgrade to latest * Change peer dep * bump to latest * format * bump 1 more rq * Update packages/tanstack-react-query/README.md Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * chore: apply lint and formatting fixes * cool * don't cross-import test * install ws * polyfill eventsource * forgot to save * whoops * merge * publish alphas * Adding docs and example project * Fix shiki by not using shiki * Add blog post * Fix * chore: apply lint and formatting fixes * Upgrade react query * Fix order mistake for providers * Remove redundant comment * undo greeting change * Fix typog * Tweaks to docs * chore: apply lint and formatting fixes * tweaks * lock * Break apart blog post a little and add dedicated migration guide * Add Why the change? * fix resource managament * simplify test * improve tests * fixes * tweak * fix * fix * tweak * rm only * more docs * aight * incude command * repub * chore: apply lint and formatting fixes * nits * nit * fix broken link * chore: apply lint and formatting fixes * typo fix * maybe fix!? * tweak docs * hmm * Update www/docs/client/tanstack-react-query/introduction.mdx Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * chore: apply lint and formatting fixes * fixy * fix nick’s bluesky * meep * re-add twoslash * tweaks * hello * tweak * fix lint-prune * fixxxtures * tweak * upstream * tweaks * split docs up * mkay * minimal react * try it out * maybe * maybe not * revert me on other pr * Revert "revert me on other pr" This reverts commit f4b969d0033bf2f068a37e37066df570a279c582. * revert me * Revert "revert me" This reverts commit d0cdf4469974223df4c7fec0c434e4cb3b865180. * revert * revert me * revert me * Revert "revert" This reverts commit ad8b1ef7a0d4cee8cd81e95c38ec442cc264d1d4. * Revert "revert me" This reverts commit 2694f69e2b2fc6e599a2f15c14fed77a4fa7ef3a. * Revert "revert me" This reverts commit 474e7e673ce2ef0b016b313a634e40b6f9bf9ef3. * lockfile * lockfile * tweak * fix: grab call expression deeper than 2 calls (#6489) Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: juliusmarminge <julius0216@outlook.com> * pub * pub * server component docs * chore: apply lint and formatting fixes * refactor: make walkers to follow Tail-call pattern (#6496) Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> * appreciation mention * add callout that you don't have to use the integration * show non-context setup * typo * rm ctx * cool * nice * fix imports * nit * cool * callout * fmt * nit * avoid internal imports as much as possible * add some more jsdoc links * cool * nits * ignore codemod in codecov * change link * portability * cool * FC * sync versions * cool * date --------- Co-authored-by: KATT <alexander@n1s.se> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Nick Lucas <Nick-Lucas@users.noreply.github.com> Co-authored-by: Nick Lucas <me@nicklucas.co.uk> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: Siddharth Gelera (reaper) <sidgroks@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tackles a few things we've spotted in tRPC:
tRPC build here: trpc/trpc#6290
fixes #8394