Skip to content

Docs: fix visible comment in query-keys.md #5736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Conversation

meatnordrink
Copy link
Contributor

@meatnordrink meatnordrink commented Jul 18, 2023

It appears that, somewhere in the course of this PR, a comment got bumped such that it's now visible in the production docs. This fixes that, as well as excludes a parenthetic that I believe was accidentally included from an italicized section, and removes some parentheses which, with the addition of a parenthetic before them via a CR suggestion, now feel confusing rather than helpful.

image

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@vercel
Copy link

vercel bot commented Jul 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Jul 18, 2023 1:55pm

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 18, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ff49705:

Sandbox Source
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@nx-cloud
Copy link

nx-cloud bot commented Jul 18, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ff49705. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@TkDodo TkDodo merged commit 8c967c7 into TanStack:main Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants