Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require only one streaming key for each course #124

Open
joschahenningsen opened this issue Sep 9, 2021 · 4 comments · May be fixed by #1323
Open

Require only one streaming key for each course #124

joschahenningsen opened this issue Sep 9, 2021 · 4 comments · May be fixed by #1323
Labels
enhancement New feature or request

Comments

@joschahenningsen
Copy link
Sponsor Member

joschahenningsen commented Sep 9, 2021

Is your feature request related to a problem? Please describe.
Currently a stream can be ingested with a streaming key (secret) which is unique for each lecture.

Describe the solution you'd like
It would be more convenient if a lecturer wouldn‘t need to reconfigure their software for every stream. A single key for the course would be sufficient.

Additional context
Users need to be able to regenerate the key if it gets leaked.

@joschahenningsen joschahenningsen added the enhancement New feature or request label Sep 9, 2021
@joschahenningsen joschahenningsen changed the title Require only one streaming key for every course Require only one streaming key for each course Sep 9, 2021
@chris246
Copy link

Yes, please

@joschahenningsen
Copy link
Sponsor Member Author

A possible consequence of this would be that a course can not have two simultaneous livestreams. This might be an issue for courses like the FVV, where English and German events are streamed at the same time.

@Mjaethers
Copy link
Contributor

Perhaps on the course > settings page there could be a tab much like the "Course Admins" tab where a lecturer can add a streaming key (secret) and name it. When creating a new lecture, these keys can be chosen from a drop-down list or an entirely new one can be generated. This would mean a lecturer could keep the configuration of their streaming software for most lectures while still allowing lecturers to use multiple keys for e.g. concurrent streams.

If this seems reasonable, I would like to work on this.

@Mjaethers
Copy link
Contributor

I see now that the above approach would require a change to the db structure, which is quite a hassle. Instead I thought that perhaps per default when creating a new stream it would use a course wide key and when necessary a new individual one could be created in the manner they currently are.
To prevent having to make a change to the db structure one could hash a secret and unique property of the course and use that as the stream key.
I noticed there is a field called Token in the course model which doesn't seem to be used anywhere. This would not even have to be hashed as it is generated (when it is generated) in the same manner stream keys currently are. Are there future plans for this Token field? Can I use it for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants