Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing shortcuts on keyboard for relevant pages #1289

Open
barisgul15 opened this issue Jan 7, 2024 · 3 comments · May be fixed by #1317
Open

Showing shortcuts on keyboard for relevant pages #1289

barisgul15 opened this issue Jan 7, 2024 · 3 comments · May be fixed by #1317
Assignees
Labels
enhancement New feature or request

Comments

@barisgul15
Copy link
Contributor

Is your feature request related to a problem? Please describe.
There are some shortcuts on tumlive, which aims to make user experience easier. However since these are not documented in a way that users can reach easily, they may be not used as expected. A general documentation is planned as we have spoken in the meetings, but this also targets mostly lecturers and even if a documentation for students is also added, as I am also a student, I think a more easier way for students will be used much more.

Describe the solution you'd like
As @alexanderstephan mentioned in #1281 here, a small keyboard logo can be added to relevant pages and when clicked, can show the shortcuts relevant. Additionally/Or depending on the shortcuts, that button can also be added in the settings page or an image showing the relevant shortcuts on keyboard can be added.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@barisgul15 barisgul15 added the enhancement New feature or request label Jan 7, 2024
@barisgul15 barisgul15 self-assigned this Jan 7, 2024
@MariusAlbrecht
Copy link

I suggest doing it like youtube:
shortcut on button hover
image
overview in menu at the top (which could perfectly be the hamburger menu for us)
image
image

Also, I personally don't think trivial or customisable keybinds need documentation.
Afaict the only keybinds present are basic media control ones and 'Esc' to close popups, these seem trivial to me.

@barisgul15 barisgul15 linked a pull request Jan 22, 2024 that will close this issue
2 tasks
@barisgul15 barisgul15 linked a pull request Jan 22, 2024 that will close this issue
2 tasks
@barisgul15
Copy link
Contributor Author

These suggestions really make sense and thats what I will implement

@goodstuff20
Copy link

It would be good if keyboard shortcuts could be customizable as well, especially since many students already use chrome extensions for video playback (slower,faster, skip...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants