Fix/issue 1856 aborted is not success #1875
Merged
+43
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relates to Issue-1625 Signed-off-by: l-1squared <30831153+l-1squared@users.noreply.github.com>
relates to Issue-1625 Signed-off-by: l-1squared <30831153+l-1squared@users.noreply.github.com>
RobertSchueler
previously approved these changes
Feb 28, 2025
| @@ -87,6 +83,8 @@ public void afterTestExecution(ExtensionContext context) throws Exception { | |||
| try { | |||
| if (context.getExecutionException().isPresent() && !ThrowableUtil.isAssumptionException(context.getExecutionException().get())) { | |||
| scenario.getExecutor().failed(context.getExecutionException().get()); | |||
| } else if (context.getExecutionException().isPresent() && ThrowableUtil.isAssumptionException(context.getExecutionException().get())) { | |||
| scenario.getExecutor().aborted(context.getExecutionException().get()); | |||
There was a problem hiding this comment.
Probably this would be a bit easier to read with a submethod that uses an early return, i.e.
if (!context.getExecutionException().isPresent()) { return;}
if (ThrowableUtil.isAssumptionException(context.getExecutionException().get())) {
scenario.getExecutor().aborted(context.getExecutionException().get());
return;
}
scenario.getExecutor().failed(context.getExecutionException().get());
There was a problem hiding this comment.
Nice.
To lazy to refactor, immediately caught :D
Signed-off-by: l-1squared <30831153+l-1squared@users.noreply.github.com>
l-1squared
force-pushed
the
fix/Issue-1856-aborted-is-not-success
branch
from
6b899c9 to
a4b18d7
Compare
RobertSchueler
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.