Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jansi very old dependency #1420

Closed
cmunger opened this issue Oct 16, 2023 · 5 comments · Fixed by #1423
Closed

Jansi very old dependency #1420

cmunger opened this issue Oct 16, 2023 · 5 comments · Fixed by #1423
Assignees

Comments

@cmunger
Copy link

cmunger commented Oct 16, 2023

jgiven core has a dependency on jansi 1.18 which is almost 5 years old, which is increasing the risk of dependencies problems with projects using the same library but with a more recent version like the 2.4.x version.

@l-1squared
Copy link
Collaborator

Thanks for bringing this to my attention.
I am a bit confused as to why renovte didn't fix that for me, but I will take a look tomorrow in the morning. (and release an update if applicable)

@l-1squared l-1squared linked a pull request Oct 18, 2023 that will close this issue
@cmunger
Copy link
Author

cmunger commented Oct 18, 2023

thanks a lot, i started on working on it but saw someone fixed it last day, we had the same fix, thanks for the quick handling of this old dependency update

@l-1squared
Copy link
Collaborator

I'm glad to hear that you arrived at the same / a similar implementation for the issue :)

@l-1squared
Copy link
Collaborator

@cmunger I have to humbly apologize that you have to wait for so long for such a simple fix. I attempted several releases over the last month, but unfortunately this PR #1396 prevents this. It fails for releases only (some gradle dependency issue with the signing plugin) and my attempts to get this done quickly have now proven disastrous.
Which unfortunately means that you have to wait a little while longer

@cmunger
Copy link
Author

cmunger commented Nov 22, 2023

No problems, I was already amazed you did the fix so fast :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants