fix importing inner class using string concat of outer field #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hankem
approved these changes
Nov 29, 2023
...t/java/com/tngtech/archunit/core/importer/ClassFileImporterSyntheticPrivateAccessesTest.java
Outdated
Show resolved
Hide resolved
...t/java/com/tngtech/archunit/core/importer/ClassFileImporterSyntheticPrivateAccessesTest.java
Outdated
Show resolved
Hide resolved
We weren't aware that the compiler occasionally generates synthetic `access$123` methods that call constructors.
More precisely for the following constellation
```
class Outer {
String field = "";
class Inner {
void concat() {
field += "any";
}
}
}
```
the compiler may generate bytecode instantiating and using a `StringBuilder` (depending on the JDK version).
But for constructor calls the synthetic access resolution was not hooked in,
because we assumed that those methods would never call a constructor.
This in turn lead to the bug
```
java.lang.IllegalStateException: Never found a JavaCodeUnit that matches supposed origin CodeUnit{name='access$123'...
```
I.e. the method `access$123` was filtered out as synthetic,
but the origin of the constructor call had not been resolved to the actual `Inner.concat` method.
Signed-off-by: Peter Gafert <peter.gafert@archunit.org>
codecholeric
force-pushed
the
fix-problem-with-synthetic-access-on-string-concat
branch
from
a6fdc9d
to
cabbe13
Compare
codecholeric
deleted the
fix-problem-with-synthetic-access-on-string-concat
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't aware that the compiler occasionally generates synthetic
access$123methods that call constructors. More precisely for the following constellationthe compiler generates bytecode instantiating and using a
StringBuilder. But for constructor calls the synthetic access resolution was not hooked in, because we assumed that those methods would never call a constructor. This in turn lead to the bugI.e. the method
access$123was filtered out as synthetic, but the origin of the constructor call had not been resolved to the actualInner.concatmethod.Resolves: #1146
Resolves: #1194