add up-to-date check for release check #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hankem
approved these changes
Dec 3, 2023
buildSrc/src/main/groovy/archunit.java-release-check-conventions.gradle
Outdated
Show resolved
Hide resolved
It happened several times that a release dependency (e.g. `slf4j-api`) was updated e.g. by Dependabot, but the respective expected POM template for the release check was forgotten to adjust. This then makes the release fail, because it thinks the produced POM file doesn't match the expected one. We now ensure during build that the release check POM file dependency versions still match the project dependencies, so this can't go out of sync anymore. Signed-off-by: Peter Gafert <peter.gafert@archunit.org>
codecholeric
force-pushed
the
ensure-release-check-stays-in-sync-with-dependency-upgrades
branch
from
a17fd24
to
69241da
Compare
codecholeric
deleted the
ensure-release-check-stays-in-sync-with-dependency-upgrades
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It happened several times that a release dependency (e.g.
slf4j-api) was updated e.g. by Dependabot, but the respective expected POM template for the release check was forgotten to adjust. This then makes the release fail, because it thinks the produced POM file doesn't match the expected one. We now ensure during build that the release check POM file dependency versions still match the project dependencies, so this can't go out of sync anymore.