fix: cache key stability #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenh
force-pushed
the
fix/all-creates-packages
branch
4 times, most recently
from
5fa5161
to
9b4b3d7
Compare
stevenh
force-pushed
the
fix/all-creates-packages
branch
2 times, most recently
from
1d5cfc6
to
d5a9bd4
Compare
Ensure consistency of main and post configuration by storing and restoring it from state, which in turn ensures cache key stability. Also: * Fixed some typos. * Use core.error for logging errors. * Fix inverted condition on cache-all-crates. Reverts: Swatinem#138 Fixes Swatinem#140
stevenh
force-pushed
the
fix/all-creates-packages
branch
from
d5a9bd4
to
68377a4
Compare
Swatinem
reviewed
May 17, 2023
Make the loading of config from state explicit by splitting into a dedicated static method.
|
@Swatinem to make sure you didn't miss the notification 😃 |
Swatinem
approved these changes
May 18, 2023
|
Thanks, appreciate your time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure consistency of main and post configuration by storing and restoring it from state, which in turn ensures cache key stability.
Also:
Reverts: #138
Fixes #140